From a44b3a9bf5477641a352f68dff58d0c0018fb0bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Kubitz?= Date: Mon, 7 Oct 2024 16:34:41 +0200 Subject: [PATCH 1/2] [test] DialogCheck: reuse VerifyDialog to reduce used OS handles try to avoid "org.eclipse.swt.SWTError: No more handles" during tests --- .../src/org/eclipse/ui/tests/harness/util/DialogCheck.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/DialogCheck.java b/tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/DialogCheck.java index ee8e19180c6..8a75f38c79e 100644 --- a/tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/DialogCheck.java +++ b/tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/DialogCheck.java @@ -104,8 +104,10 @@ public static void assertDialogTexts(Dialog dialog) { public static Shell getShell() { Shell shell = PlatformUI.getWorkbench() .getActiveWorkbenchWindow().getShell(); - _verifyDialog = new VerifyDialog(shell); - _verifyDialog.create(); + if (_verifyDialog == null) { + _verifyDialog = new VerifyDialog(shell); + _verifyDialog.create(); + } return _verifyDialog.getShell(); } From a19d070964b03559f70de48439a1503517b536cf Mon Sep 17 00:00:00 2001 From: Eclipse Platform Bot Date: Mon, 7 Oct 2024 14:39:43 +0000 Subject: [PATCH 2/2] Version bump(s) for 4.34 stream --- tests/org.eclipse.ui.tests.harness/META-INF/MANIFEST.MF | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/org.eclipse.ui.tests.harness/META-INF/MANIFEST.MF b/tests/org.eclipse.ui.tests.harness/META-INF/MANIFEST.MF index 08849c0c87c..ed65721730f 100644 --- a/tests/org.eclipse.ui.tests.harness/META-INF/MANIFEST.MF +++ b/tests/org.eclipse.ui.tests.harness/META-INF/MANIFEST.MF @@ -2,7 +2,7 @@ Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-Name: Harness Plug-in Bundle-SymbolicName: org.eclipse.ui.tests.harness;singleton:=true -Bundle-Version: 1.10.400.qualifier +Bundle-Version: 1.10.500.qualifier Eclipse-BundleShape: dir Require-Bundle: org.eclipse.ui, org.eclipse.core.runtime,