WhitespaceCharacterPainter: fix off-by-one error at CR and LF offsets #2418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 1 818 files ±0 1 818 suites ±0 1h 37m 6s ⏱️ + 2m 19s For more details on these failures, see this check. Results for commit f85523a. ± Comparison against base commit 929564c. |
Member
|
random failing test is already reported in #294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following screenshot shows the incorrect behavior:
And here a screenshot with the changes of this pull request:
The first line contains a carriage return and line feed character, the second line 5 space characters and a code mining with text "label" at the end of the line.
The 5 space characters were drawn at the first line by mistake.