Skip to content

[win] Adding experimental preference to enable update on runtime behavior #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

[win] Adding experimental preference to enable update on runtime behavior #2461

merged 1 commit into from
Oct 31, 2024

Conversation

@ShahzaibIbrahim
Copy link
Contributor

@ShahzaibIbrahim ShahzaibIbrahim commented Oct 29, 2024 •
edited by HeikoKlare
Loading

In the UI Preferences -> General -> Appearance, there is a new HiDPI setting that could be checked to enable the monitor-specific scaling of the UI. This check will also enable Edge browser by default. This is an experimental feature to test the multi-monitor HiDPI support before it is actually released and set by default. For now, this preference is disabled by default.

Note: This preference check is only available in Windows

image

When changing the preference, the dialog will appear to prompt the restart.

image

@laeubi
Copy link
Contributor

laeubi commented Oct 29, 2024

As we have ways to know the platform, maybe only show it when running on windows?

Also either make PerMonitorV2 a link to some documentation or remove implementation details from the description.

@ShahzaibIbrahim
Copy link
Contributor Author

ShahzaibIbrahim commented Oct 29, 2024

As we have ways to know the platform, maybe only show it when running on windows?

@laeubi Forgot to mention but yes, we are only showing it in Windows. I have updated the description.

@laeubi
Copy link
Contributor

laeubi commented Oct 29, 2024

If it is only shown on windows, then I don't think it needs to be mentioned as a "Windows only" in the text.

@BeckerWdf
Copy link
Member

BeckerWdf commented Oct 29, 2024

Also either make PerMonitorV2 a link to some documentation or remove implementation details from the description.

One could also add such details into the documentation page for this preference page.

@ShahzaibIbrahim
Copy link
Contributor Author

ShahzaibIbrahim commented Oct 29, 2024

@BeckerWdf @laeubi for now I have removed implementation details from the description. I have asked if we have documentation page for this right now. If yes, then I will link it.

@ShahzaibIbrahim ShahzaibIbrahim linked an issue Oct 29, 2024 that may be closed by this pull request
Add experimental preference to enable update on runtime behavior vi-eclipse/Eclipse-Platform#134
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 43m 42s ⏱️ - 10m 43s
 7 724 tests ±0   7 495 ✅ ±0  228 💤 ±0  1 ❌ ±0 
24 333 runs  ±0  23 585 ✅ ±0  747 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit a2bbf11. ± Comparison against base commit 83c128c.

♻️ This comment has been updated with latest results.

fedejeanne
fedejeanne previously requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works pretty well, I only have some minor comments about naming/typos and one important detail about preserving the selected browser when the new preference is set to false.

@ShahzaibIbrahim ShahzaibIbrahim force-pushed the master-134 branch 2 times, most recently from ffccae6 to a05574d Compare October 30, 2024 14:56
@fedejeanne fedejeanne dismissed their stale review October 31, 2024 05:57

My changes have been applied. Rebasing.

HeikoKlare
HeikoKlare requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to finally have a proper preference for enabling the enhanced HiDPI support on Windows, thanks!

Still, in the current state, this PR introduces a regression and needs some revision regarding design and naming. See my detailed comments.

@ShahzaibIbrahim ShahzaibIbrahim force-pushed the master-134 branch 2 times, most recently from c641c89 to 351988b Compare October 31, 2024 13:10
HeikoKlare
HeikoKlare reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding functionality, this looks good now (except for the case that the options do not show up anymore because of a faulty conditions).

Some minor code style comments are remaining.

@HeikoKlare HeikoKlare changed the title Adding experimental preference to enable update on runtime behavior [win] Adding experimental preference to enable update on runtime behavior Oct 31, 2024
@ShahzaibIbrahim @HeikoKlare
Adding experimental preference to enable rescaling at runtime (Windows)
a2bbf11 
In the UI Preferences -> General -> Appearance, there is a new HiDPI
setting that could be checked to enable the monitor-specific scaling of
the UI. This check will also enable Edge browser by default. This is an
experimental feature to test the multi-monitor HiDPI support before it
is actually released and set by default. For now, this preference is
disabled by default.
HeikoKlare
HeikoKlare approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, this also looks good now. Thank you!

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Oct 31, 2024

Failing test is unrelated/already documented: #370

@HeikoKlare HeikoKlare merged commit c5928bb into eclipse-platform:master Oct 31, 2024
15 of 17 checks passed
@HeikoKlare HeikoKlare mentioned this pull request Nov 1, 2024
Merged
@HeikoKlare HeikoKlare added the noteworthy Noteworthy feature label Nov 1, 2024
@ShahzaibIbrahim ShahzaibIbrahim mentioned this pull request Nov 4, 2024
Closed
ShahzaibIbrahim added a commit to ShahzaibIbrahim/www.eclipse.org-eclipse that referenced this pull request Nov 4, 2024
@ShahzaibIbrahim
Added N&N for experimental HiDpi setting
b388d4c 
Issue: vi-eclipse/Eclipse-Platform#134
PR: eclipse-platform/eclipse.platform.ui#2461
HeikoKlare pushed a commit to HeikoKlare/www.eclipse.org-eclipse that referenced this pull request Nov 5, 2024
@ShahzaibIbrahim @HeikoKlare
Added N&N for monitor-specific UI rescaling on Windows
45f63e9 
eclipse-platform/eclipse.platform.ui#2461
@HeikoKlare HeikoKlare mentioned this pull request Nov 5, 2024
Merged
HeikoKlare pushed a commit to HeikoKlare/www.eclipse.org-eclipse that referenced this pull request Nov 5, 2024
@ShahzaibIbrahim @HeikoKlare
Added N&N for monitor-specific UI rescaling on Windows
bbf056b 
eclipse-platform/eclipse.platform.ui#2461
HeikoKlare pushed a commit to HeikoKlare/www.eclipse.org-eclipse that referenced this pull request Nov 5, 2024
@ShahzaibIbrahim @HeikoKlare
Added N&N for monitor-specific UI rescaling on Windows
d72825b 
eclipse-platform/eclipse.platform.ui#2461
HeikoKlare pushed a commit to eclipse-platform/www.eclipse.org-eclipse that referenced this pull request Nov 6, 2024
@ShahzaibIbrahim @HeikoKlare
Added N&N for monitor-specific UI rescaling on Windows
415b202 
eclipse-platform/eclipse.platform.ui#2461
@Bananeweizen Bananeweizen mentioned this pull request Dec 16, 2024
Open
@Bananeweizen Bananeweizen mentioned this pull request Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fedejeanne fedejeanne fedejeanne approved these changes

@HeikoKlare HeikoKlare HeikoKlare approved these changes

@BeckerWdf BeckerWdf BeckerWdf approved these changes

Assignees

No one assigned

Labels

noteworthy Noteworthy feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add experimental preference to enable update on runtime behavior

5 participants

@ShahzaibIbrahim @laeubi @BeckerWdf @HeikoKlare @fedejeanne