Bugfix for #2453: NPE in BarContentAssistProcessor.

[nettozahler]

This bugfix simply adds a check for NULL which was missing. In case of NULL a default value is returned. Fxes #2453

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From b9433e179e84806fe885206a3d11ea6bdf724c26 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sun, 3 Nov 2024 21:58:54 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF
index f95c0ce33f..a3dd34a3a5 100644
--- a/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.genericeditor.tests;singleton:=true
-Bundle-Version: 1.3.500.qualifier
+Bundle-Version: 1.3.600.qualifier
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.ui.genericeditor.tests,
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 48m 42s ⏱️ + 3m 8s
 7 724 tests ±0   7 496 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 333 runs  ±0  23 586 ✅ ±0  747 💤 ±0  0 ❌ ±0 

Results for commit 113a645. ± Comparison against base commit c1c681a.

[mickaelistria]

While null-check are always welcome, I'm more curious about in which context can this issue be happening? The document isn't supposed to be null at that stage, so maybe the issue is earlier in the execution chain?

[nettozahler]

Since the affected class belongs to test code and the NPE happens when locally running org.eclipse.ui.genericeditor.tests.CompletionTest I suggest not to spend more time for further investigations until this bug occurs in productive code. Deeper investigations would be out of my personal scope anyway.