[Linux-Dark Theme]Background color issue fix in form editor #2569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labels in form editor was not inheriting colors from the parent control which later led to too many background colors in section, label and other controls in linux. This has been fixed with this change.
Contributor
Author
|
@vogella Could you please test this? I could not take the screenshot after the changes from my virtual desktop as there is some issue, to upload the image here. Could you please help upload the 'After' image here? |
Contributor
Test Results 1 514 files - 307 1 514 suites - 307 1h 24m 17s ⏱️ - 28m 13s For more details on these failures, see this check. Results for commit e65e226. ± Comparison against base commit 6c459cc. This pull request skips 1 test. |
Contributor
|
Looks similar to me:
|
Contributor
Author
|
After |
Contributor
|
Thanks @mvm-sap looks (after testing again) also great for me.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue reported in #2555
Before:
