Skip to content

ToolItemUpdater: fix possible Integer overflow #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024
Merged

ToolItemUpdater: fix possible Integer overflow #2572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0862575
ToolItemUpdater: fix possible Integer overflow
jukzi Dec 3, 2024
2596333
Version bump(s) for 4.35 stream
eclipse-platform-bot Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-SymbolicName: org.eclipse.e4.ui.workbench.renderers.swt;singleton:=true
Bundle-Version: 0.16.600.qualifier
Bundle-Version: 0.16.700.qualifier
Bundle-Name: %pluginName
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
2 changes: 1 addition & 1 deletion ...orkbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolItemUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public void updateContributionItems(Selector selector) {
if (timestampOfEarliestQueuedUpdate == 0) {
timestampOfEarliestQueuedUpdate = System.nanoTime();
}
if (System.nanoTime() - timestampOfEarliestQueuedUpdate > DELAY * 1_000_000) {
if (System.nanoTime() - timestampOfEarliestQueuedUpdate > DELAY * 1_000_000L) {
// runnable was not called within the last DELAY milliseconds, do it now.
// For scenario: a plugin is forcing that updateContributionItems is called
// again and again in less than given DELAY frequency. TimerExec would then
Expand Down
Loading