Revert "Use SubMonintor in TextChange" #2586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2f68c39.
jukzi
added
bug
Contributor
Test Results 1 821 files ±0 1 821 suites ±0 2h 1m 50s ⏱️ + 5m 32s For more details on these failures, see this check. Results for commit 18ce343. ± Comparison against base commit ea68ca2. |
Contributor
|
Revert is fine for me for now, see the JDT report for analysis, I might get back to remove this call with the full consumption of units of work of the submonitor as the JDT test is testing for in a later commit. |
vogella
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2573
see eclipse-jdt/eclipse.jdt.ui#1833