From 87db8ad7421c60cff26616dc8771e930bf2698ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=B6rg=20Kubitz?= <joerg.kubitz@ssi-schaefer.com>
Date: Tue, 14 Jan 2025 17:12:35 +0100
Subject: [PATCH] Remove stacktrace from DataFormatException but add raw value
 #2521

looks less scary

https://github.com/eclipse-platform/eclipse.platform.ui/issues/2521
---
 .../org/eclipse/ui/internal/themes/ColorDefinition.java     | 6 +++---
 tests/org.eclipse.ui.tests/plugin.xml                       | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/themes/ColorDefinition.java b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/themes/ColorDefinition.java
index 35e00089bc6..bf39b5108fc 100644
--- a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/themes/ColorDefinition.java
+++ b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/themes/ColorDefinition.java
@@ -14,11 +14,11 @@
 package org.eclipse.ui.internal.themes;
 
 import org.eclipse.core.runtime.IStatus;
+import org.eclipse.core.runtime.Status;
 import org.eclipse.e4.ui.internal.css.swt.definition.IColorDefinitionOverridable;
 import org.eclipse.jface.resource.DataFormatException;
 import org.eclipse.swt.graphics.RGB;
 import org.eclipse.ui.IPluginContribution;
-import org.eclipse.ui.internal.misc.StatusUtil;
 import org.eclipse.ui.statushandlers.StatusManager;
 import org.eclipse.ui.themes.ColorUtil;
 
@@ -111,8 +111,8 @@ public RGB getValue() {
 				parsedValue = ColorUtil.getColorValue(rawValue);
 			} catch (DataFormatException e) {
 				parsedValue = DEFAULT_COLOR_VALUE;
-				IStatus status = StatusUtil.newStatus(IStatus.WARNING,
-						"Could not parse value for theme color " + getId(), e); //$NON-NLS-1$
+				IStatus status = Status
+						.warning("Could not parse value for theme color " + getId() + ":  \"" + rawValue + "\""); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
 				StatusManager.getManager().handle(status, StatusManager.LOG);
 			}
 		}
diff --git a/tests/org.eclipse.ui.tests/plugin.xml b/tests/org.eclipse.ui.tests/plugin.xml
index 2e16cdb6ef3..fe98d113121 100644
--- a/tests/org.eclipse.ui.tests/plugin.xml
+++ b/tests/org.eclipse.ui.tests/plugin.xml
@@ -2621,7 +2621,7 @@
       </colorDefinition>    
       <colorDefinition
             label="badColor3"
-            value="0,0, 1x"
+            value="0,0, 1IntentionalBadColor3inorg.eclipse.ui.tests/plugin.xml"
             id="badColor3">
       </colorDefinition>  
       <fontDefinition