Skip to content

Do not use Java editor in back/forward test #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Do not use Java editor in back/forward test #2703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 32 additions & 38 deletions ...org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/GoBackForwardsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2024 IBM Corporation and others.
* Copyright (c) 2000, 2025 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -57,27 +57,21 @@ public GoBackForwardsTest() {
private static final String FILE_CONTENTS = "public class GoBackForwardsTestFile {\n"
+ " public static void main(String[] args) {\n" + " System.out.println(\"Hello world!\");\n"
+ " }\n" + "}";
private static final String JAVA_EDITOR_ID = "org.eclipse.jdt.ui.CompilationUnitEditor";
private static final String TEXT_EDITOR_ID = "org.eclipse.ui.genericeditor.GenericEditor";
private static final String GENERIC_EDITOR_ID = "org.eclipse.ui.genericeditor.GenericEditor";
private static final String TEXT_EDITOR_ID = "org.eclipse.ui.DefaultTextEditor";
private static final String SELECTION_STRING = "Selection<offset: 10, length: 5>";

private IProject project;
private IFile file;

@Override
public void doSetUp() {
try {
project = FileUtil.createProject(PROJECT_NAME);
file = FileUtil.createFile(FILE_NAME, project);
StringBuilder stringBuilder = new StringBuilder();
stringBuilder.append(FILE_CONTENTS);
Files.writeString(Paths.get(file.getLocation().toOSString()), stringBuilder);
project.refreshLocal(IResource.DEPTH_INFINITE, null);
} catch (CoreException e) {
fail("Should not throw an exception");
} catch (IOException e) {
fail("Should not throw an exception");
}
public void doSetUp() throws CoreException, IOException {
project = FileUtil.createProject(PROJECT_NAME);
file = FileUtil.createFile(FILE_NAME, project);
StringBuilder stringBuilder = new StringBuilder();
stringBuilder.append(FILE_CONTENTS);
Files.writeString(Paths.get(file.getLocation().toOSString()), stringBuilder);
project.refreshLocal(IResource.DEPTH_INFINITE, null);

}

Expand All @@ -88,22 +82,22 @@ public void testNavigationHistoryNavigation() {

processEvents();

Condition javaEditorNoSelection = currentNavigationHistoryLocationCondition(JAVA_EDITOR_ID, false);
Condition javaEditorSelection = currentNavigationHistoryLocationCondition(JAVA_EDITOR_ID, true);
Condition genericEditorNoSelection = currentNavigationHistoryLocationCondition(GENERIC_EDITOR_ID, false);
Condition genericEditorSelection = currentNavigationHistoryLocationCondition(GENERIC_EDITOR_ID, true);
Condition textEditorNoSelection = currentNavigationHistoryLocationCondition(TEXT_EDITOR_ID, false);
Condition textEditorSelection = currentNavigationHistoryLocationCondition(TEXT_EDITOR_ID, true);

FileEditorInput editorInput = new FileEditorInput(file);

openJavaEditor(editorInput);
openGenericEditor(editorInput);

if (!processEventsUntil(javaEditorNoSelection, 1000)) {
if (!processEventsUntil(genericEditorNoSelection, 1000)) {
fail("Timeout during navigation." + getStateDetails());
}

selectInJavaEditor(editorInput);
selectInGenericEditor(editorInput);

if (!processEventsUntil(javaEditorSelection, 1000)) {
if (!processEventsUntil(genericEditorSelection, 1000)) {
fail("Timeout during navigation." + getStateDetails());
}

Expand All @@ -119,9 +113,9 @@ public void testNavigationHistoryNavigation() {
fail("Timeout during navigation." + getStateDetails());
}

openJavaEditor(editorInput);
openGenericEditor(editorInput);

if (!processEventsUntil(javaEditorSelection, 1000)) {
if (!processEventsUntil(genericEditorSelection, 1000)) {
fail("Timeout during navigation." + getStateDetails());
}

Expand All @@ -131,11 +125,11 @@ public void testNavigationHistoryNavigation() {
fail("Timeout during navigation." + getStateDetails());
}

// Navigate backward from text editor to java editor
goBackward(EditorTestHelper.getActiveWorkbenchWindow(), javaEditorSelection);
// Navigate backward from text editor to editor
goBackward(EditorTestHelper.getActiveWorkbenchWindow(), genericEditorSelection);
Assert.assertEquals(
"Failed to correctly navigate backward from text editor to java editor." + getStateDetails(),
JAVA_EDITOR_ID, getActiveEditorId());
GENERIC_EDITOR_ID, getActiveEditorId());

// Navigate backward from java editor to text editor
goBackward(EditorTestHelper.getActiveWorkbenchWindow(), textEditorSelection);
Expand All @@ -150,16 +144,16 @@ public void testNavigationHistoryNavigation() {
TEXT_EDITOR_ID, getActiveEditorId());

// Navigate backward from java editor to java editor
goBackward(EditorTestHelper.getActiveWorkbenchWindow(), javaEditorSelection);
goBackward(EditorTestHelper.getActiveWorkbenchWindow(), javaEditorNoSelection);
goBackward(EditorTestHelper.getActiveWorkbenchWindow(), genericEditorSelection);
goBackward(EditorTestHelper.getActiveWorkbenchWindow(), genericEditorNoSelection);
Assert.assertEquals(
"Failed to correctly navigate backward from java editor to java editor." + getStateDetails(),
JAVA_EDITOR_ID, getActiveEditorId());
GENERIC_EDITOR_ID, getActiveEditorId());

// Navigate forward from java editor to java editor
goForward(EditorTestHelper.getActiveWorkbenchWindow(), javaEditorSelection);
goForward(EditorTestHelper.getActiveWorkbenchWindow(), genericEditorSelection);
Assert.assertEquals("Failed to correctly navigate forward from java editor to java editor." + getStateDetails(),
JAVA_EDITOR_ID, getActiveEditorId());
GENERIC_EDITOR_ID, getActiveEditorId());

// Navigate forward from text editor to text editor
goForward(EditorTestHelper.getActiveWorkbenchWindow(), textEditorNoSelection);
Expand All @@ -168,9 +162,9 @@ public void testNavigationHistoryNavigation() {
TEXT_EDITOR_ID, getActiveEditorId());

// Navigate forward from text editor to java editor
goForward(EditorTestHelper.getActiveWorkbenchWindow(), javaEditorSelection);
goForward(EditorTestHelper.getActiveWorkbenchWindow(), genericEditorSelection);
Assert.assertEquals("Failed to correctly navigate forward from text editor to java editor." + getStateDetails(),
JAVA_EDITOR_ID, getActiveEditorId());
GENERIC_EDITOR_ID, getActiveEditorId());

// Navigate forward from java editor to text editor
goForward(EditorTestHelper.getActiveWorkbenchWindow(), textEditorSelection);
Expand All @@ -190,19 +184,19 @@ private Condition currentNavigationHistoryLocationCondition(String editorId, boo
};
}

private void openJavaEditor(IEditorInput editorInput) {
private void openGenericEditor(IEditorInput editorInput) {
try {
EditorTestHelper.getActivePage().openEditor(editorInput, JAVA_EDITOR_ID, true,
EditorTestHelper.getActivePage().openEditor(editorInput, GENERIC_EDITOR_ID, true,
IWorkbenchPage.MATCH_ID | IWorkbenchPage.MATCH_INPUT);
} catch (PartInitException e) {
fail("Should not throw an exception");
}
}

private void selectInJavaEditor(IEditorInput editorInput) {
private void selectInGenericEditor(IEditorInput editorInput) {
try {
AbstractTextEditor editor = (AbstractTextEditor) EditorTestHelper.getActivePage().openEditor(editorInput,
JAVA_EDITOR_ID, true, IWorkbenchPage.MATCH_ID | IWorkbenchPage.MATCH_INPUT);
GENERIC_EDITOR_ID, true, IWorkbenchPage.MATCH_ID | IWorkbenchPage.MATCH_INPUT);
editor.selectAndReveal(10, 5);
} catch (PartInitException e) {
fail("Should not throw an exception");
Expand Down
Loading