Skip to content

Activate monitor-specific scaling before Display instantiation #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

Activate monitor-specific scaling before Display instantiation #2704

merged 1 commit into from
Jan 15, 2025
+6 −5

Conversation

@HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Jan 15, 2025 •
edited
Loading

Monitor-specific scaling needs to be activated before the display that is supposed to run in that mode is created. Currently, the scaling is activated in the Workbench based on an according preference after the Display has already been created.

This change moves the evaluation of the experimental preference and the according initialization of monitor-specific scaling to before the Display is created inside the Workbench.
In addition, the disclaimer is cleaned up from the statement about Edge, which is now already been enabled by default.

@HeikoKlare HeikoKlare force-pushed the monitor-specific-scaling-before-display-creation branch from 7fd118a to 2d53a65 Compare January 15, 2025 13:18
@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Jan 15, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 7524be3b73d7e101d6a90f90d027bc1fddd687a3 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Wed, 15 Jan 2025 13:22:54 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
index 2a8197c69e..98a8744054 100644
--- a/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.ide.application;singleton:=true
-Bundle-Version: 1.5.600.qualifier
+Bundle-Version: 1.5.700.qualifier
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.ui.ide;bundle-version="[3.21.0,4.0.0)",
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited
Loading

Test Results

 1 817 files   -  1   1 817 suites   - 1   1h 29m 51s ⏱️ + 2m 22s
 7 733 tests ± 0   7 504 ✅  -  1  228 💤 ± 0  1 ❌ +1 
24 315 runs   - 45  23 575 ✅  - 36  739 💤  - 10  1 ❌ +1 

For more details on these failures, see this check.

Results for commit bbdbb0d. ± Comparison against base commit 871538d.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the monitor-specific-scaling-before-display-creation branch from 1c67cea to 6008972 Compare January 15, 2025 14:44
@HeikoKlare HeikoKlare changed the title Move experimental monitor-specific scaling preference to IDEApplication Activate monitor-specific scaling before Display instantiation Jan 15, 2025
@HeikoKlare HeikoKlare force-pushed the monitor-specific-scaling-before-display-creation branch 2 times, most recently from 57778fa to abfa8ee Compare January 15, 2025 14:46
@HeikoKlare HeikoKlare marked this pull request as ready for review January 15, 2025 14:47
@HeikoKlare
Activate monitor-specific scaling before Display instantiation
bbdbb0d 
Monitor-specific scaling needs to be activated before the display that
is supposed to run in that mode is created. Currently, the scaling is
activated in the Workbench based on an according preference after the
Display has already been created.

This change moves the evaluation of the experimental preference and the
according initialization of monitor-specific scaling to before the
Display is created inside the Workbench.
In addition, the disclaimer is cleaned up from the statement about Edge,
which is now already been enabled by default.
@HeikoKlare HeikoKlare force-pushed the monitor-specific-scaling-before-display-creation branch from abfa8ee to bbdbb0d Compare January 15, 2025 16:09
akoch-yatta
akoch-yatta approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@akoch-yatta akoch-yatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the change and from it looks solid and sound to me. Moving the initialization before the Display creation is definitely necessary.

@HeikoKlare
Copy link
Contributor Author

HeikoKlare commented Jan 15, 2025

Failing test first occurred in this PR, but is completely unrelated to the change. It was documented here:

@HeikoKlare HeikoKlare merged commit 3587081 into eclipse-platform:master Jan 15, 2025
15 of 17 checks passed
@HeikoKlare HeikoKlare deleted the monitor-specific-scaling-before-display-creation branch January 15, 2025 18:08
@HeikoKlare HeikoKlare mentioned this pull request Jan 15, 2025
Closed
@iloveeclipse iloveeclipse mentioned this pull request Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoch-yatta akoch-yatta akoch-yatta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HeikoKlare @eclipse-platform-bot @akoch-yatta