Skip to content

Conversation

@Christopher-Hermann
Copy link
Contributor

Sticky lines should be shown when the file is opened via search view.

Fixes #2678

Sticky lines should be shown when the file is opened via search view.

Fixes eclipse-platform#2678
@github-actions
Copy link
Contributor

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 34m 26s ⏱️ + 1m 37s
 7 739 tests ±0   7 511 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 378 runs  ±0  23 629 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit e1fff31. ± Comparison against base commit 24c7c0b.

@iloveeclipse
Copy link
Member

iloveeclipse commented Jan 17, 2025

With steps below I still don't see sticky area in JNITypeParser > typeNameToSignature():

  1. Open String#replace(char, char)
  2. Search all references in the workspace
  3. Open jdk.jdi > com.sun.tools.jdi > JNITypeParser > typeNameToSignature() (bug: no area)
  4. Open jdk.jfr.internal.instrument > JIMethodMergeAdapter > JIMethodMergeAdapter(ClassVisitor, ClassNode, List, JITypeMapping[]) (sticky area shown now)
  5. Go back to JNITypeParser > typeNameToSignature() (sticky area shown now)

@Christopher-Hermann
Copy link
Contributor Author

Hmm, that's strange. It is working for me. Can you see anything that I might have done differently?

2025-01-17_13-08-57.mp4

@iloveeclipse
Copy link
Member

Can you see anything that I might have done differently?

I'm on Linux and I don't use Css themes. Later one could be more important, as themes cause lot of extra painting / layout overhead.

@iloveeclipse
Copy link
Member

I see where the problem is: I've tested #2719, not this PR.
I've now fecthed this one on top of other and with that, it seem to work.

@iloveeclipse iloveeclipse merged commit dbf808e into eclipse-platform:master Jan 17, 2025
17 checks passed
@Christopher-Hermann Christopher-Hermann deleted the fixStickyScrollingViaSearch branch January 24, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StickyScrolling: Exceptions while opening Java editors from Search view

2 participants