Skip to content

Conversation

@reedenb
Copy link
Contributor

@reedenb reedenb commented Jan 27, 2025

  • Add preferences import and export help contexts to IWorkbenchHelpContextIds.java
  • Register missing help contexts for WizardPreferencesExportPage1.java and WizardPreferencesImportPage1.java to the help system.

Fixes #2759

@reedenb reedenb changed the title Issues/2759 Help not shown in "Import preferences" dialog #2759 Jan 27, 2025
@reedenb
Copy link
Contributor Author

reedenb commented Jan 27, 2025

continuous-integration/jenkins/pr-head build failure due to error: Error fetching URL: https://docs.osgi.org/javadoc/osgi.enterprise/7.0.0/ (java.net.ConnectException: Connection timed out) during javadoc generation for bundles/org.eclipse.ui.workbench.texteditor

@github-actions
Copy link
Contributor

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 32m 15s ⏱️ +45s
 7 717 tests ±0   7 489 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 312 runs  ±0  23 563 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 8cfccdc. ± Comparison against base commit 1042a13.

@deepika-u
Copy link
Contributor

I have tried applying this pr and looks like issue still persists. Nothing happens when i click on "Import Preferences" -> help.

image

@reedenb
Copy link
Contributor Author

reedenb commented Jan 28, 2025

I have tried applying this pr and looks like issue still persists. Nothing happens when i click on "Import Preferences" -> help.

image

@deepika-u can you share more details regarding which release and OS you are on? I have this working with eclipse-committers-2025-03-M1-win32-x86_64.

image

I do realize I should use the newer setHelp method which is e4 safe. Will make the changes.

@reedenb reedenb marked this pull request as draft January 28, 2025 11:30
@reedenb reedenb closed this Jan 28, 2025
@reedenb
Copy link
Contributor Author

reedenb commented Jan 28, 2025

New PR for issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Help not shown in "Import preferences" dialog

2 participants