-
Notifications
You must be signed in to change notification settings - Fork 228
Help not shown in "Import preferences" dialog #2759 #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add preferences import and export help contexts to IWorkbenchHelpContextIds.java - Register missing help contexts for WizardPreferencesExportPage1.java and WizardPreferencesImportPage1.java to the help system. Fixes eclipse-platform#2759
Test Results 1 821 files ±0 1 821 suites ±0 1h 30m 42s ⏱️ - 5m 23s For more details on these failures, see this check. Results for commit 5d879f9. ± Comparison against base commit 92e290e. |
|
@fedejeanne Does this look okay? |
|
@deepika-u how are you testing the applied pr? Doesn't look like you're running a new product from the ide. |
You are right, after applying the pr, i took a child workspace and see that your fix works for me. Thanks for correcting me. |
|
@deepika-u happy to help :) |
|
So this is read to merge? |
|
@BeckerWdf there's 1 test failure in Test Results specific to MacOS. I'm assuming it's flaky. I think this is ready to merge. |
|
Thanks @reedenb for the contribution. |


Fixes #2759