[StickyScrolling] Prevent out of bounds errors by validating sticky l… #2769
Conversation
Test Results 1 821 files ±0 1 821 suites ±0 1h 27m 34s ⏱️ - 3m 1s For more details on these failures, see this check. Results for commit 055c002. ± Comparison against base commit 9f3733a. ♻️ This comment has been updated with latest results. |
Christopher-Hermann
force-pushed
the
fixAIE
branch
from
a22509c to
e2d42b2
Compare
|
The change seem to break some test cases. |
|
@Christopher-Hermann : do you have time to work on this? In 10 days we have M3... |
|
Yes, I will take care of it. At latest on Friday this week. |
Christopher-Hermann
force-pushed
the
fixAIE
branch
from
e2d42b2 to
a62e5ae
Compare
…ine number Handle cases where the sticky line number exceeds the total number of lines to prevent out of bounds errors. Since widgetLineNumber is 0-based, ensure it is not equal to or greater than the line count. Fixes eclipse-platform#2765
Christopher-Hermann
force-pushed
the
fixAIE
branch
from
a62e5ae to
055c002
Compare
|
failing ProgressViewTests seems unrelated. |
|
Anyone want to review that or can we merge? (I'm not familiar with the code) |
I will merge, the changes are not that big...should be fine. |
Christopher-Hermann
merged commit bd93b33
into
eclipse-platform:master
|
Thanks @Christopher-Hermann. |
3 participants
…ine number
Handle cases where the sticky line number exceeds the total number of lines to prevent out of bounds errors. Since widgetLineNumber is 0-based, ensure it is not equal to or greater than the line count.
Fixes #2765