fix CodeMiningLineHeaderAnnotation#getMultilineHeight #2787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Member
|
This PR seem to reduce redraw count, see also #2788 where you can count them with tracing option |
Member
|
Please rebase on master |
tobiasmelcher
force-pushed
the
editor_content_jumps
branch
2 times, most recently
from
ac4f037 to
edf3294
Compare
it should never return 0. Fix race condition when code minings are not yet available. eclipse-platform#2786
tobiasmelcher
force-pushed
the
editor_content_jumps
branch
from
edf3294 to
b506f3d
Compare
Contributor
Test Results 1 821 files ±0 1 821 suites ±0 1h 34m 37s ⏱️ + 6m 44s For more details on these failures, see this check. Results for commit b506f3d. ± Comparison against base commit c9f129d. |
Member
|
testSingleSelectionAndTwoInitialSelectionsWithInitialPattern (UiTestSuite org.eclipse.ui.tests.dialogs.FilteredResourcesSelectionDialogTestSuite org.eclipse.ui.tests.dialogs.ResourceInitialSelectionTest) looks anrelated |
Member
|
@tobiasmelcher : I'm not familiar with the code, so not right person for a review. @mickaelistria maybe? |
BeckerWdf
requested review from
mickaelistria
and removed request for
iloveeclipse
mickaelistria
merged commit 433cdb9
into
eclipse-platform:master
15 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should never return 0. Fix race condition when code minings are not yet available.
#2786