Test Results

 2 778 files  ± 0   2 778 suites  ±0   1h 36m 42s ⏱️ - 7m 29s
 7 943 tests +11   7 714 ✅ +11  228 💤 ±0  1 ❌ ±0 
23 384 runs  +33  22 637 ✅ +33  746 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit da38e3d. ± Comparison against base commit 477d106.

♻️ This comment has been updated with latest results.

@danthe1st : thanks for PR, few things:

1. Please rebase on master
2. Please squash two commits into one
3. Please update commit message to follow commit message guidelines: https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

@danthe1st : thanks for PR, few things:

1. Please rebase on master

2. Please squash two commits into one

3. Please update commit message to follow commit message guidelines: https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

I'll make sure to do that once I located and fixed a remaining issue in combination with JDT (if I select a method that's within a custom folding region and enter text, it seems to show "too much" text for some reason). While I think that's an issue with JDT-UI (it only seems to happen with custom folding regions and extended folding), I want to be sure about it first (and I opened this PR before everything is finished to make it visible in advance/allow for discussion if applicable).

I have made the requested changes. However, I want to note the following:

• This has an impact on behavior(al compatibility). If some project/plugin/whatever calls enableProjections() and setVisibleRegion on some ProjectionViewer, this PR affects what is shown to the user.
• I didn't do performance testing.
• I think it would be a good idea for someone from JDT (or other projects if make use of this?) to test it before this is merged.

I am not sure why the Jenkins build seems to have issues getting tycho set up (maybe issues with https://repo.eclipse.org/?)

Yes there are infrastructure problems again:

• https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/6377
• https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/6378

I restarted the build.

It looks like there was a test failure:

https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-3074/lastCompletedBuild/testReport/

I now switched to an approach that should have fewer side effects. Instead of adding additional projection regions, I am now using the expand() and collapse() methods directly.

Thank you for your review. I made the requested changes and updated the description.

Just a hint: for all the comments you have resolved, please use "Resolve Conversation" button so it is easier to see what is left open.

I am not sure in what ways my changes are related (assuming they are related) to the test failure on MacOS (and I don't have a MacOS device to test it on).

It might be related to #294

Any chance this feature be available in the next Eclipse version 2025-09 ?

Any chance this feature be available in the next Eclipse version 2025-09 ?

I don't think so (and I don't think it would be a good idea even if that was reviewed and deemed ok content-wise now) since we are approaching RC1 and as this change could impact other parts of the IDE and maybe also RCP application, it would be ideal if it was merged before even M1 (so if there are issues originating from it, there is enough time to fix them before a release).

That being said, I think the implementation is at a point where it can be re-reviewed, especially since this bugfix has been merged. One thing I'm not quite sure about (yet) is the following note in the PR description:

Expanding a folding region outside the currently visible region will make that folding region visible. If wanted, I can change that.

I (think I) could make it so that expanding folding regions that may have parts outside of the visible regions just ignores these parts.

Thank you for your reply and all the great work you have done so far
So I guess there are still problem with this. I just thought since it passed all the tests it is ready to be merged.

You said
"Expanding a folding region outside the currently visible region will make that folding region visible. If wanted, I can change that."

But how is that possible since when you invoke show only selected element you only see the code of the selected element on the file you are coding lets call the file file a. how can you expand on something outside of selected element on file a ? unless you are saying that if you expand a region on a different file lets call it file b then it will disable the show only selected element on file a ?
That is really a no good file b should affect file a. It should be fixed changed

Do you think there is any chance this feature will be merged in the next version of Eclipse after 202509 like 202512 ?
I hope it will cause I am looking forward for this feature.

It's possible this hasn't been merged until now because I didn't care enough to ask for a re-review 😂 (I guess I should rebase and do that after the 2025-09 release)

But how is that possible since when you invoke show only selected element you only see the code of the selected element on the file you are coding lets call the file file a. how can you expand on something outside of selected element on file a ? unless you are saying that if you expand a region on a different file lets call it file b then it will disable the show only selected element on file a ?

This PR is about the change in platform.ui which provides the APIs relevant for that. If a client decides they want to show projection regions in a way that these are not entirely within or outside of folding regions, they can do so (and in fact, this situation can also occur with custom folding regions where one comment is inside the visible region and the other isn't). This decision is something I'd like to get the opinions of the committers/possibly other people.

Regarding the tests, I think there are still 3 that didn't run with the current version yet and IIRC some tests failed there with MacOS on previous versions (and I don't have a MacOS device to fix these issues if they originate from this PR). These tests would likely be executed when a committer reviews it (or clicks on the button to approve the test run which has to be redone whenever a new version is pushed because I haven't contributed to platform.ui before).

Also I don't know how big the effects of this PR are on other code based on Eclipse that isn't JDT (e.g. companies building RCP applications).

Do you think there is any chance this feature will be merged in the next version of Eclipse after 202509 like 202512 ?

¯\_(ツ)_/¯