Skip to content

Simple fix for NPE in ProjectionViewer.resetVisibleRegion #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Simple fix for NPE in ProjectionViewer.resetVisibleRegion #3460

merged 1 commit into from
Oct 28, 2025

Conversation

@iloveeclipse
Copy link
Member

@iloveeclipse iloveeclipse commented Oct 27, 2025

Only fix for places changed in ce17c9e and related to NPE's on fProjectionAnnotationModel.

The code in ProjectionViewer in general assumes
fProjectionAnnotationModel to be non null in most places where it might access it. Probably this needs to be revisited.

Fixes #3459

@iloveeclipse iloveeclipse mentioned this pull request Oct 27, 2025
Closed
2 tasks
@iloveeclipse
Copy link
Member Author

iloveeclipse commented Oct 27, 2025

Build on Jenkins fails with OOM

[ERROR] download from https://download.eclipse.org/eclipse/updates/4.38-I-builds/I20251025-0900/plugins/org.eclipse.jface.examples.databinding_1.4.600.v20250312-0643.jar failed: selector manager closed: Java heap space

This is most likely same as eclipse-platform/eclipse.platform.releng.aggregator#3436
Possible workaround eclipse-platform/eclipse.platform.releng.aggregator#3437

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025 •
edited
Loading

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 21m 15s ⏱️ - 1m 59s
 8 234 tests ±0   7 985 ✅ ±0  249 💤 ±0  0 ❌ ±0 
23 622 runs  ±0  22 828 ✅ ±0  794 💤 ±0  0 ❌ ±0 

Results for commit f7afd25. ± Comparison against base commit 1563627.

♻️ This comment has been updated with latest results.

@iloveeclipse
Copy link
Member Author

iloveeclipse commented Oct 27, 2025

Still OOM's

Exception in thread "HttpClient-11-SelectorManager" java.lang.OutOfMemoryError: Java heap space
Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Worker-0"
Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Worker-2"
Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "HttpClient-9-SelectorManager"
Exception in thread "HttpClient-2-SelectorManager" java.lang.OutOfMemoryError: Java heap space
Exception in thread "HttpClient-10-SelectorManager" java.lang.OutOfMemoryError: Java heap space
Exception in thread "HttpClient-6-SelectorManager" 09:37:35.555 [ERROR] Java heap space -> [Help 1]

See eclipse-platform/eclipse.platform.releng.aggregator#3436

@iloveeclipse iloveeclipse mentioned this pull request Oct 27, 2025
Closed
@iloveeclipse
Simple fix for NPE in ProjectionViewer.resetVisibleRegion
f7afd25 
Only fix for places changed in ce17c9e and related to NPE's on
`fProjectionAnnotationModel`.

The code in `ProjectionViewer` in general assumes
`fProjectionAnnotationModel` to be non null in most places where it
might access it. Probably this needs to be revisited.

Fixes eclipse-platform#3459
@iloveeclipse iloveeclipse merged commit e3022d8 into eclipse-platform:master Oct 28, 2025
18 checks passed
@iloveeclipse iloveeclipse deleted the issue_3459 branch October 28, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NPE in ProjectionViewer.resetVisibleRegion

1 participant

@iloveeclipse