Skip to content

In Project Explorer, ensure "Select All" (Ctrl+A and menu) works reliably irrespective of first or subsequent selections. #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+62 −6
Open

In Project Explorer, ensure "Select All" (Ctrl+A and menu) works reliably irrespective of first or subsequent selections. #3534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 62 additions & 6 deletions bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonNavigator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
*******************************************************************************/
package org.eclipse.ui.navigator;

import org.eclipse.core.commands.AbstractHandler;
import org.eclipse.core.commands.ExecutionEvent;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.PerformanceStats;
import org.eclipse.core.runtime.SafeRunner;
Expand All @@ -29,18 +31,25 @@
import org.eclipse.jface.viewers.TreeViewer;
import org.eclipse.jface.viewers.ViewerFilter;
import org.eclipse.swt.SWT;
import org.eclipse.swt.events.KeyAdapter;
import org.eclipse.swt.events.KeyEvent;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.ui.IEditorInput;
import org.eclipse.ui.IMemento;
import org.eclipse.ui.IPartListener2;
import org.eclipse.ui.ISaveablePart;
import org.eclipse.ui.ISaveablesLifecycleListener;
import org.eclipse.ui.ISaveablesSource;
import org.eclipse.ui.IViewSite;
import org.eclipse.ui.IWorkbenchCommandConstants;
import org.eclipse.ui.IWorkbenchPartReference;
import org.eclipse.ui.PartInitException;
import org.eclipse.ui.PlatformUI;
import org.eclipse.ui.Saveable;
import org.eclipse.ui.SaveablesLifecycleEvent;
import org.eclipse.ui.actions.ActionGroup;
import org.eclipse.ui.handlers.IHandlerActivation;
import org.eclipse.ui.handlers.IHandlerService;
import org.eclipse.ui.internal.navigator.CommonNavigatorActionGroup;
import org.eclipse.ui.internal.navigator.NavigatorContentService;
import org.eclipse.ui.internal.navigator.NavigatorPlugin;
Expand Down Expand Up @@ -160,6 +169,8 @@ public class CommonNavigator extends ViewPart implements ISetSelectionTarget, IS

private LinkHelperService linkService;

private IPartListener2 partListener;

public CommonNavigator() {
super();
}
Expand Down Expand Up @@ -255,6 +266,47 @@ public void handleLifecycleEvent(SaveablesLifecycleEvent event) {
ColumnViewerToolTipSupport.enableFor(commonViewer);
}

// Immediate fallback: handle Ctrl+A at the Tree level
commonViewer.getTree().addKeyListener(new KeyAdapter() {
@Override
public void keyPressed(KeyEvent e) {
Copy link
Contributor

@merks merks Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow it seems like a hack to handle this one key directly, especially given the key binding appears to be configurable:

Image

Copy link
Member

@iloveeclipse iloveeclipse Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, CommonViewer is a base class in CNF and can be extended. Adding key and part listeners that consumes key or register handlers here directly might affect others code. So please carefully change the code here, it is not only about Project Explorer.

Copy link
Contributor Author

@deepika-u deepika-u Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow it seems like a hack to handle this one key directly, especially given the key binding appears to be configurable:

Let me check on it.

// MOD1 = Ctrl on Win/Linux, Command on macOS
if ((e.stateMask & SWT.MOD1) != 0 && (e.keyCode == 'a' || e.keyCode == 'A')) {
commonViewer.getTree().selectAll();
e.doit = false;
}
}
});

// Activate the 'Select All' command handler when the view is active
partListener = new IPartListener2() {
private IHandlerActivation activation;

@Override
public void partActivated(IWorkbenchPartReference ref) {
if (ref.getPart(false) == CommonNavigator.this) {
IHandlerService hs = getSite().getService(IHandlerService.class);
activation = hs.activateHandler(IWorkbenchCommandConstants.EDIT_SELECT_ALL, new AbstractHandler() {
@Override
public Object execute(ExecutionEvent event) {
commonViewer.getTree().selectAll();
return null;
}
});
}
}

@Override
public void partDeactivated(IWorkbenchPartReference ref) {
if (ref.getPart(false) == CommonNavigator.this && activation != null) {
IHandlerService hs = getSite().getService(IHandlerService.class);
hs.deactivateHandler(activation);
activation = null;
}
}
};
getSite().getPage().addPartListener(partListener);

stats.endRun();
}

Expand Down Expand Up @@ -308,13 +360,17 @@ public String getFrameToolTipText(Object anElement) {
*/
@Override
public void dispose() {
if (commonManager != null) {
commonManager.dispose();
}
if (commonActionGroup != null) {
commonActionGroup.dispose();
try {
getSite().getPage().removePartListener(partListener);
if (commonManager != null) {
commonManager.dispose();
}
if (commonActionGroup != null) {
commonActionGroup.dispose();
}
} finally {
super.dispose();
}
super.dispose();
}

/**
Expand Down
Loading