Skip to content

Conversation

@deepika-u
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 13m 31s ⏱️ -23s
 8 234 tests ±0   7 985 ✅ ±0  249 💤 ±0  0 ❌ ±0 
23 622 runs  ±0  22 828 ✅ ±0  794 💤 ±0  0 ❌ ±0 

Results for commit a50012a. ± Comparison against base commit 200996c.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

@deepika-u Have you looked into what would cause to not use this method in console? It is what I would rather see be done rather than this push/revert.

@deepika-u deepika-u force-pushed the deprecated_methods_4_2 branch from 274f3ba to 089ee6f Compare November 12, 2025 14:17
@deepika-u
Copy link
Contributor Author

@akurtakov
Instead of calling the deprecated getVisibleLinesInViewport method, the line count can be computed inline within the caller, as I have access to the fTextWidget object. However, the limitation noted in the deprecation still applies - results may be inaccurate when the widget uses variable line heights. I will continue investigating potential approaches. Do you have any suggestions on how this could be achieved?

@akurtakov
Copy link
Member

I haven't found the time to look into it at all. It's the general approach how things should happen in this case that I pointed out.

@deepika-u deepika-u force-pushed the deprecated_methods_4_2 branch from 089ee6f to a50012a Compare November 13, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants