Fix flaky ResourceInitialSelectionTest.testSingleSelectionAndTwoInitialSelectionsWithInitialPattern

[vogella]

Summary

Improves the fix for the intermittent test failure in ResourceInitialSelectionTest.testSingleSelectionAndTwoInitialSelectionsWithInitialPattern that was still occasionally failing in CI despite the fix in commit 87352d6.

Problem with Existing Fix

The fix added in commit 87352d6 (Oct 25, 2025) added a waitForDialogRefresh() helper method but used a fixed-time wait of only 150ms (3 iterations × 50ms), which proved insufficient on slower systems like macOS CI.

Root Cause

1. FilteredResourcesSelectionDialog.refresh() triggers async background jobs: FilterHistoryJob → FilterJob → RefreshCacheJob → RefreshJob
2. These jobs populate the table and apply initial selections asynchronously
3. The original fix waited only 150ms total
4. On slower machines or under load, async operations take longer to complete
5. Test checked selection before it was applied: expected:<[L/.../foo.txt]> but was:<[]>

Improved Solution

Enhanced waitForDialogRefresh() to use a condition-based approach:

private void waitForDialogRefresh() {
    Display display = PlatformUI.getWorkbench().getDisplay();
    
    // Wait up to 2 seconds for table to be populated (condition-based)
    DisplayHelper.waitForCondition(display, 2000, () -> {
        processUIEvents();
        try {
            Table table = getDialogTable();
            return table.getItemCount() > 0;
        } catch (Exception e) {
            return false;
        }
    });
    
    // Then wait 250ms for selection to be applied
    for (int i = 0; i < 5; i++) {
        processUIEvents();
        Thread.sleep(50);
    }
    
    processUIEvents();
}

Improvements:

• Condition-based wait for table population (up to 2 seconds, returns immediately when ready)
• Increased selection wait from 150ms to 250ms (5 × 50ms)
• Faster on fast systems: Returns immediately when table is populated
• More reliable on slow systems: Up to 2 seconds for async jobs to complete
• Test time: ~9 seconds (vs ~16 seconds with longer fixed waits, ~3-4 seconds with original insufficient wait)

Changes

• Modified waitForDialogRefresh() in ResourceInitialSelectionTest.java:454-489
• Uses DisplayHelper.waitForCondition() for table population check
• Builds on existing fix from commit 87352d6 (which already added the method and calls to 10 tests)

Testing

• ✅ All 13 tests pass consistently
• ✅ Verified with 3+ consecutive test runs - 0 failures
• ✅ Test execution time: ~8-9 seconds (acceptable trade-off for reliability)
• ✅ Works on both fast and slow systems

Related

• Builds on fix from commit 87352d6 (Oct 25, 2025)
• Addresses continuing flaky test failures in CI

🤖 Generated with Claude Code

[github-actions]

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 20m 52s ⏱️ + 6m 45s
 8 234 tests ±0   7 985 ✅ ±0  249 💤 ±0  0 ❌ ±0 
23 622 runs  ±0  22 828 ✅ ±0  794 💤 ±0  0 ❌ ±0 

Results for commit c3b9438. ± Comparison against base commit 7a24db1.

♻️ This comment has been updated with latest results.