Perform clean code of terminal/bundles/org.eclipse.terminal.connector.process

Author: eclipse-platform-bot

terminal/bundles/org.eclipse.terminal.connector.process/src/org/eclipse/terminal/connector/process/ProcessConnector.java

@@ -194,8 +194,9 @@ public void connect(ITerminalControl control) {
 
 			// Enable VT100 line wrapping if we are connected via pty
 			// And TERM is VT100 compatible
-			if (pty != null && !isAnsiTerminal)
+			if (pty != null && !isAnsiTerminal) {
 				control.setVT100LineWrapping(true);
+			}
 
 			// connect the streams
 			connectStreams(control, process.getOutputStream(), process.getInputStream(),
@@ -214,8 +215,9 @@ public void connect(ITerminalControl control) {
 			Shell shell = control.getShell();
 			// Lookup the tab item
 			CTabItem item = ConsoleManager.getInstance().findConsole(control);
-			if (item != null)
+			if (item != null) {
 				item.dispose();
+			}
 			// Get the error message from the exception
 			String msg = e.getLocalizedMessage() != null ? e.getLocalizedMessage() : ""; //$NON-NLS-1$
 			Assert.isNotNull(msg);
@@ -229,10 +231,13 @@ public void connect(ITerminalControl control) {
 	}
 
 	private static String getTermVariable(String[] envp) {
-		if (envp != null && !Platform.OS_WIN32.equals(Platform.getOS()))
-			for (String var : envp)
-				if (var.startsWith("TERM=")) //$NON-NLS-1$
+		if (envp != null && !Platform.OS_WIN32.equals(Platform.getOS())) {
+			for (String var : envp) {
+				if (var.startsWith("TERM=")) { //$NON-NLS-1$
 					return var.substring(5);
+				}
+			}
+		}
 		return "xterm"; //$NON-NLS-1$
 	}
 

terminal/bundles/org.eclipse.terminal.connector.process/src/org/eclipse/terminal/connector/process/ProcessLauncherDelegate.java

@@ -61,16 +61,17 @@ public ITerminalConnector createTerminalConnector(Map<String, Object> properties
 
 		// Check for the terminal connector id
 		String connectorId = (String) properties.get(ITerminalsConnectorConstants.PROP_TERMINAL_CONNECTOR_ID);
-		if (connectorId == null)
+		if (connectorId == null) {
 			connectorId = "org.eclipse.terminal.connector.process.ProcessConnector"; //$NON-NLS-1$
+		}
 
 		// Extract the process properties
 		String image = (String) properties.get(ITerminalsConnectorConstants.PROP_PROCESS_PATH);
 		String arguments = (String) properties.get(ITerminalsConnectorConstants.PROP_PROCESS_ARGS);
 		Process process = (Process) properties.get(ITerminalsConnectorConstants.PROP_PROCESS_OBJ);
 		PTY pty = (PTY) properties.get(ITerminalsConnectorConstants.PROP_PTY_OBJ);
 		Object value = properties.get(ITerminalsConnectorConstants.PROP_LOCAL_ECHO);
-		boolean localEcho = value instanceof Boolean ? ((Boolean) value).booleanValue() : false;
+		boolean localEcho = value instanceof Boolean b ? b.booleanValue() : false;
 		String lineSeparator = (String) properties.get(ITerminalsConnectorConstants.PROP_LINE_SEPARATOR);
 		ITerminalServiceOutputStreamMonitorListener[] stdoutListeners = (ITerminalServiceOutputStreamMonitorListener[]) properties
 				.get(ITerminalsConnectorConstants.PROP_STDOUT_LISTENERS);
@@ -106,7 +107,7 @@ public ITerminalConnector createTerminalConnector(Map<String, Object> properties
 		if (properties.containsKey(ITerminalsConnectorConstants.PROP_PROCESS_MERGE_ENVIRONMENT)) {
 			value = properties.get(ITerminalsConnectorConstants.PROP_PROCESS_MERGE_ENVIRONMENT);
 			processSettings
-					.setMergeWithNativeEnvironment(value instanceof Boolean ? ((Boolean) value).booleanValue() : false);
+					.setMergeWithNativeEnvironment(value instanceof Boolean b ? b.booleanValue() : false);
 		}
 
 		// And save the settings to the store

terminal/bundles/org.eclipse.terminal.connector.process/src/org/eclipse/terminal/connector/process/ProcessMonitor.java

@@ -48,8 +48,9 @@ public void dispose() {
 		// Set the disposed status
 		disposed = true;
 		// Not initialized -> return immediately
-		if (thread == null)
+		if (thread == null) {
 			return;
+		}
 
 		// Copy the reference
 		final Thread oldThread = thread;
@@ -64,8 +65,9 @@ public void dispose() {
 	 */
 	public void startMonitoring() {
 		// If already initialized -> return immediately
-		if (thread != null)
+		if (thread != null) {
 			return;
+		}
 
 		// Create a new runnable which is constantly reading from the stream
 		Runnable runnable = () -> monitorProcess();
@@ -86,8 +88,9 @@ public void startMonitoring() {
 	 */
 	public void monitorProcess() {
 		// If already disposed -> return immediately
-		if (disposed)
+		if (disposed) {
 			return;
+		}
 
 		try {
 			// Wait for the monitored process to terminate
@@ -97,8 +100,9 @@ public void monitorProcess() {
 			Thread.interrupted();
 		} finally {
 			// Dispose the parent process connector
-			if (!disposed)
+			if (!disposed) {
 				processConnector.disconnect();
+			}
 		}
 	}
 }

terminal/bundles/org.eclipse.terminal.connector.process/src/org/eclipse/terminal/connector/process/ProcessSettings.java

@@ -113,8 +113,9 @@ public Process getProcess() {
 	public void setPTY(PTY pty) {
 		this.pty = pty;
 		// If the PTY is set to "null", the local echo will be set to "true"
-		if (pty == null)
+		if (pty == null) {
 			setLocalEcho(true);
+		}
 	}
 
 	/**