Skip to content

Commit 418952d

Browse files
committed
Add splash to o.e.sdk Plug-in and update it in new dev-cycle preparation
The org.eclipse.sdk branding-plugin was missing the splash-screen, similar to the other branding-plugin org.eclipse.platform. This enables the splash-screen when running the 'org.eclipse.sdk.ide' product in launch configurations for secondary Eclipse instances. Additionally the about-dialog branding-icon and the (now new) splash-screen in org.eclipse.sdk weren't updated during the preparation of a new development cycle, again like org.eclipse.platform.
1 parent 8594fad commit 418952d

File tree

3 files changed

+20
-15
lines changed

3 files changed

+20
-15
lines changed

platform/org.eclipse.sdk/build.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ bin.includes = about.html,\
2828
plugin.properties,\
2929
plugin_customization.ini,\
3030
plugin_customization.properties,\
31+
splash.png,\
3132
META-INF/,\
3233
book.css,\
3334
disabled_book.css,\
201 KB
Loading

prepareNextDevCycle.sh

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,25 @@
1818
# and applies the changes required individually for Eclipse-Platform.
1919
# The calling pipeline also defines environment variables usable in this script.
2020

21-
pushd 'platform/org.eclipse.platform'
22-
23-
if [ ! -f splash.png ] || [ ! -f eclipse_lg.png ] || [ ! -f eclipse_lg@2x.png ]; then
24-
echo 'Expected target Splash-screen or branding images are missing'
25-
# Probably the naming or file format of any of these files has changed and this script wasn't adapted.
26-
exit 1
27-
fi
28-
29-
# Update splash-screen
30-
mv -f futureSplashScreens/splash_${NEXT_RELEASE_NAME}.png splash.png
31-
if [ -f 'futureSplashScreens/eclipse_lg.png' ]; then
32-
# About-dialog image is usally the same for multiple releases
33-
mv -f futureSplashScreens/eclipse_lg.png eclipse_lg.png
34-
mv -f futureSplashScreens/eclipse_lg@2x.png eclipse_lg@2x.png
35-
fi
21+
pushd 'platform'
22+
brandingPlugins=('org.eclipse.platform' 'org.eclipse.sdk')
23+
for plugin in "${brandingPlugins[@]}"; do
24+
25+
if [ ! -f "${plugin}/splash.png" ] || [ ! -f "${plugin}/eclipse_lg.png" ] || [ ! -f "${plugin}/eclipse_lg@2x.png" ]; then
26+
echo "Expected target Splash-screen or branding images are missing for plugin ${plugin}"
27+
# Probably the naming or file format of any of these files has changed and this script wasn't adapted.
28+
exit 1
29+
fi
30+
31+
# Update splash-screen
32+
cp -f "org.eclipse.platform/futureSplashScreens/splash_${NEXT_RELEASE_NAME}.png" "${plugin}/splash.png"
33+
if [ -f 'org.eclipse.platform/futureSplashScreens/eclipse_lg.png' ]; then
34+
# About-dialog image is usally the same for multiple releases
35+
cp -f org.eclipse.platform/futureSplashScreens/eclipse_lg*.png ${plugin}
36+
fi
37+
done
38+
rm "org.eclipse.platform/futureSplashScreens/splash_${NEXT_RELEASE_NAME}.png"
39+
rm org.eclipse.platform/futureSplashScreens/eclipse_lg*.png
3640
popd
3741

3842
git commit --all --message "Splash Screen for ${NEXT_RELEASE_VERSION} (${NEXT_RELEASE_NAME})"

0 commit comments

Comments
 (0)