Remove sorting parameter from ConfigurationSessionTestSuite #903

The ConfigurationSessionTestSuite sorts the test methods by default. A
field identifies whether sorting is activated, but the field cannot even
be set but is always true. So, this parameterization is completely
obsolete and only introduces unnecessary complexity to the session test
framework.

Contributes to
#903

Author: HeikoKlare

runtime/tests/org.eclipse.core.tests.harness/src/org/eclipse/core/tests/session/ConfigurationSessionTestSuite.java

@@ -62,12 +62,9 @@ public class ConfigurationSessionTestSuite extends SessionTestSuite {
 	private IPath configurationPath = FileSystemHelper.getRandomLocation(FileSystemHelper.getTempDir());
 	private boolean prime = true;
 	private boolean readOnly;
-	// should the test cases be run in alphabetical order?
-	private boolean shouldSort;
 
 	public ConfigurationSessionTestSuite(String pluginId, Class<?> theClass) {
 		super(pluginId, theClass);
-		this.shouldSort = true;
 	}
 
 	public ConfigurationSessionTestSuite(String pluginId, String name) {
@@ -269,11 +266,6 @@ public void run(TestResult result) {
 					fail(e);
 				}
 			}
-			if (!shouldSort) {
-				// for shared sessions, we don't control the execution of test cases
-				super.run(result);
-				return;
-			}
 			// we have to sort the tests cases
 			Test[] allTests = getTests(true);
 			// now run the tests in order