Perform clean code of debug/org.eclipse.ui.console

Author: eclipse-platform-bot

debug/org.eclipse.ui.console/src/org/eclipse/ui/console/actions/TextViewerGotoLineAction.java

@@ -111,7 +111,7 @@ public void run() {
 			fLastLine= document.getLineOfOffset(document.getLength()) + 1;
 			int startLine= selection == null ? 1 : fTextViewer.getTextWidget().getLineAtOffset(selection.x) + 1;
 			String title= ConsoleMessages.TextViewerGotoLineAction_Go_To_Line_1;
-			String message= MessageFormat.format(ConsoleMessages.TextViewerGotoLineAction_Enter_line_number__8, new Object[] {Integer.valueOf(fLastLine)});
+			String message= MessageFormat.format(ConsoleMessages.TextViewerGotoLineAction_Enter_line_number__8, Integer.valueOf(fLastLine));
 			String value= Integer.toString(startLine);
 			Shell activeShell= fTextViewer.getTextWidget().getShell();
 			InputDialog d= new InputDialog(activeShell, title, message, value, new NumberValidator());

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleDropDownAction.java

@@ -141,8 +141,7 @@ public void run() {
 	@Override
 	public void runWithEvent(Event event) {
 		// Show menu on drop-down button, run action otherwise
-		if (event.detail == SWT.ARROW && event.widget instanceof ToolItem) {
-			ToolItem toolItem = (ToolItem) event.widget;
+		if (event.detail == SWT.ARROW && event.widget instanceof ToolItem toolItem) {
 			Control control = toolItem.getParent();
 			Menu menu = getMenu(control);
 

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleManager.java

@@ -355,8 +355,7 @@ public void showConsoleView(final IConsole console) {
 	 */
 	private boolean shouldBringToTop(IConsole console, IViewPart consoleView) {
 		boolean bringToTop = true;
-		if (consoleView instanceof IConsoleView) {
-			IConsoleView cView = (IConsoleView) consoleView;
+		if (consoleView instanceof IConsoleView cView) {
 			if (cView.isPinned()) {
 				IConsole pinnedConsole = cView.getConsole();
 				bringToTop = console.equals(pinnedConsole);
@@ -416,8 +415,7 @@ public IPatternMatchListener[] createPatternMatchListeners(IConsole console) {
 					continue;
 				}
 
-				if (console instanceof TextConsole && extension.isEnabledFor(console)) {
-					TextConsole textConsole = (TextConsole) console;
+				if (console instanceof TextConsole textConsole && extension.isEnabledFor(console)) {
 					PatternMatchListener patternMatchListener = new PatternMatchListener(extension);
 					try {
 						textConsole.addPatternMatchListener(patternMatchListener);

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java

@@ -260,8 +260,7 @@ protected void updateTitle() {
 	protected void updateHelp() {
 		IConsole console = getConsole();
 		String helpContextId = null;
-		if (console instanceof AbstractConsole) {
-			AbstractConsole abs = (AbstractConsole) console;
+		if (console instanceof AbstractConsole abs) {
 			helpContextId = abs.getHelpContextId();
 		}
 		if (helpContextId == null) {
@@ -474,8 +473,7 @@ protected void configureToolBar(IToolBarManager mgr) {
 		mgr.add(fDisplayConsoleAction);
 		if (fOpenConsoleAction != null) {
 			mgr.add(fOpenConsoleAction);
-			if (mgr instanceof ToolBarManager) {
-				ToolBarManager tbm= (ToolBarManager) mgr;
+			if (mgr instanceof ToolBarManager tbm) {
 				final ToolBar tb= tbm.getControl();
 				tb.addMouseListener(new MouseAdapter() {
 					@Override
@@ -704,8 +702,7 @@ public void partDeactivated(IWorkbenchPartReference partRef) {
 	 * @return true if the specified part reference is the console view
 	 */
 	protected boolean isThisPart(IWorkbenchPartReference partRef) {
-		if (partRef instanceof IViewReference) {
-			IViewReference viewRef = (IViewReference) partRef;
+		if (partRef instanceof IViewReference viewRef) {
 			if (getViewSite() != null && viewRef.getId().equals(getViewSite().getId())) {
 				String secId = viewRef.getSecondaryId();
 				String mySec = null;

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java

@@ -718,7 +718,7 @@ private boolean offer(PendingPartition p) {
 	/**
 	 * Holds data until updateJob can be run and the document can be updated.
 	 */
-	private class PendingPartition {
+	private static class PendingPartition {
 		private final CharSequence text;
 		private final IOConsoleOutputStream stream;
 

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/OpenConsoleAction.java

@@ -75,8 +75,7 @@ public void dispose() {
 
 	@Override
 	public void runWithEvent(Event event) {
-		if (event.widget instanceof ToolItem) {
-			ToolItem toolItem= (ToolItem) event.widget;
+		if (event.widget instanceof ToolItem toolItem) {
 			Control control= toolItem.getParent();
 			Menu menu= getMenu(control);
 

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/PatternMatchListenerExtension.java

@@ -87,7 +87,7 @@ public Expression getEnablementExpression() throws CoreException {
 		if (fEnablementExpression == null) {
 			IConfigurationElement[] elements = fConfig.getChildren(ExpressionTagNames.ENABLEMENT);
 			if (elements.length == 0) {
-				String message = MessageFormat.format("{0} " + getLocalId() + " {1} " + getPluginId() + " {2}", new Object[] { ConsoleMessages.PatternMatchListenerExtension_3, ConsoleMessages.PatternMatchListenerExtension_4, ConsoleMessages.PatternMatchListenerExtension_5 }); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
+				String message = MessageFormat.format("{0} " + getLocalId() + " {1} " + getPluginId() + " {2}", ConsoleMessages.PatternMatchListenerExtension_3, ConsoleMessages.PatternMatchListenerExtension_4, ConsoleMessages.PatternMatchListenerExtension_5); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
 				ConsolePlugin.log(new Status(IStatus.WARNING, ConsolePlugin.getUniqueIdentifier(), IStatus.OK, message, null));
 			}
 			IConfigurationElement enablement = elements.length > 0 ? elements[0] : null;

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ansi/commands/EnableDisableHandler.java

@@ -64,8 +64,7 @@ public void updateElement(UIElement element, Map parameters) {
 	// it has a "dummy" event that I've created.
 	private static boolean wasMyEvent(ExecutionEvent executionEvent) {
 		Object trigger = executionEvent.getTrigger();
-		if (trigger instanceof Event) {
-			Event internalEvent = (Event) trigger;
+		if (trigger instanceof Event internalEvent) {
 			if (internalEvent.time == 0 && internalEvent.type == 0) { // My event
 				return true;
 			}