GH-2167 Launch Group never terminates when many configurations are

disabled

The previous patch was not completely fixed the issue.

Fix issue
#2167

Signed-off-by: Pauline DEVILLE <[email protected]>

Author: pdeville2

debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/groups/GroupLaunchConfigurationDelegate.java

@@ -96,14 +96,10 @@ public void launch(ILaunchConfiguration groupConfig, String mode, final ILaunch
 			SubMonitor progress = SubMonitor.convert(monitor, NLS.bind(DebugCoreMessages.GroupLaunchConfigurationDelegate_Launching, groupConfig.getName()), 1000);
 
 			List<GroupLaunchElement> launches = createLaunchElements(groupConfig);
-			int nbEnabledLaunches = launches.stream().filter(l -> l.enabled).toList().size();
-			for (int i = 0; i < launches.size(); ++i) {
+			List<GroupLaunchElement> enabledLaunches = launches.stream().filter(l -> l.enabled).toList();
+			for (int i = 0; i < enabledLaunches.size(); ++i) {
 				GroupLaunchElement le = launches.get(i);
 
-				if (!le.enabled) {
-					continue;
-				}
-
 				// find launch; if not found, skip (error?)
 				final ILaunchConfiguration conf = findLaunchConfiguration(le.name);
 				if (conf == null) {
@@ -128,7 +124,7 @@ public void launch(ILaunchConfiguration groupConfig, String mode, final ILaunch
 					// loop detected. report as appropriate and die.
 					IStatusHandler cycleHandler = DebugPlugin.getDefault().getStatusHandler(GROUP_CYCLE);
 					cycleHandler.handleStatus(GROUP_CYCLE, conf.getName());
-				} else if (!launchChild(progress.newChild(1000 / nbEnabledLaunches), group, le, conf, localMode, (i == nbEnabledLaunches - 1))) {
+				} else if (!launchChild(progress.newChild(1000 / enabledLaunches.size()), group, le, conf, localMode, (i == enabledLaunches.size() - 1))) {
 					break;
 				}