Skip to content

Commit 7a1ca86

Browse files
rubenporrasfedejeanne
authored andcommitted
do not verify proxy data during initialization #1951
as it produces "System property {0} has been set to {1} by an external source. This value will be overwritten using the values from the preferences" when the user sets the system properties to avoid the info message "System property {0} is not set but should be {1}" Fixes #1951
1 parent cefa31f commit 7a1ca86

File tree

1 file changed

+1
-4
lines changed
  • team/bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net

1 file changed

+1
-4
lines changed

team/bundles/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyType.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -543,10 +543,7 @@ private void updateSocksSystemProperties() {
543543
}
544544

545545
public void initialize() {
546-
// On mac, the system proxy configuration is set by the JVM automatically
547-
boolean isMac = "macosx".equals(System.getProperty("osgi.os")); //$NON-NLS-1$//$NON-NLS-2$
548-
int verify = isMac ? DO_NOT_VERIFY : VERIFY_EMPTY;
549-
updateSystemProperties(getProxyData(verify));
546+
updateSystemProperties(getProxyData(DO_NOT_VERIFY));
550547
preferenceManager.addNodeChangeListener(PREF_PROXY_DATA_NODE, this);
551548
preferenceManager.addPreferenceChangeListener(getPreferenceNode(), this);
552549
}

0 commit comments

Comments
 (0)