ant: remove wrong @SuppressWarnings("unused")

Author: EcljpseB0T

ant/org.eclipse.ant.launching/META-INF/MANIFEST.MF

@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Localization: plugin
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ant.launching;singleton:=true
-Bundle-Version: 1.4.400.qualifier
+Bundle-Version: 1.4.500.qualifier
 Bundle-Activator: org.eclipse.ant.internal.launching.AntLaunching
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.debug.core;bundle-version="[3.12.0,4.0.0)",

ant/org.eclipse.ant.launching/common/org/eclipse/ant/internal/launching/debug/AntDebugState.java

@@ -16,7 +16,6 @@
 
 import java.util.HashMap;
 import java.util.Hashtable;
-import java.util.Iterator;
 import java.util.Map;
 import java.util.Stack;
 import java.util.Vector;
@@ -35,9 +34,7 @@ public class AntDebugState {
 	private static final String fgAntCallTaskName = "antcall"; //$NON-NLS-1$
 
 	private final IDebugBuildLogger fLogger;
-	@SuppressWarnings("unused")
 	private final Stack<Task> fTasks = new Stack<>();
-	@SuppressWarnings("unused")
 	private final Map<Task, Object> fTaskToProxies = new HashMap<>();
 	private Task fCurrentTask;
 	private Task fStepOverTask;
@@ -50,9 +47,7 @@ public class AntDebugState {
 
 	private Map<Project, Vector<?>> fProjectToTargetNames = null;
 	private Map<Project, Map<Target, Vector<Target>>> fProjectToMapOfTargetToBuildSequence = null;
-	@SuppressWarnings("unused")
 	private final Stack<Target> fTargetsToExecute = new Stack<>();
-	@SuppressWarnings("unused")
 	private final Stack<Target> fTargetsExecuting = new Stack<>();
 
 	private boolean fConsiderTargetBreakpoints = false;
@@ -65,7 +60,6 @@ public AntDebugState(IDebugBuildLogger logger) {
 		fLogger = logger;
 	}
 
-	@SuppressWarnings("unused")
 	public void buildStarted() {
 		fProjectToTargetNames = new HashMap<>();
 		fProjectToMapOfTargetToBuildSequence = new HashMap<>();
@@ -306,7 +300,6 @@ public void targetStarted(BuildEvent event) {
 			Object ref = eventProject.getReference(IAntCoreConstants.TARGET_VECTOR_NAME);
 			if (ref != null) {
 				fProjectToTargetNames.put(eventProject, (Vector<?>) ref);
-				@SuppressWarnings("unused")
 				HashMap<Target, Vector<Target>> targetToBuildSequence = new HashMap<>();
 				setTargetToExecute(initializeBuildSequenceInformation(event, targetToBuildSequence));
 				fProjectToMapOfTargetToBuildSequence.put(eventProject, targetToBuildSequence);
@@ -429,9 +422,7 @@ public void marshalStack(StringBuffer stackRepresentation) {
 				// sub build target dependencies
 				String targetName = task.getOwningTarget().getName();
 				if (targetName != null && targetName.length() != 0) { // skip for implicit target
-					Iterator<Target> itr = fTargetsToExecute.iterator();
-					while (itr.hasNext()) {
-						Target target = itr.next();
+					for (Target target : fTargetsToExecute) {
 						if (target.getProject() != projectExecuting) {
 							targetToExecute = target;
 							continue;

ant/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote/EclipseDefaultExecutor.java

@@ -25,7 +25,6 @@ public class EclipseDefaultExecutor extends DefaultExecutor {
 
 	private static final EclipseSingleCheckExecutor SUB_EXECUTOR = new EclipseSingleCheckExecutor();
 
-	@SuppressWarnings("unused")
 	@Override
 	public void executeTargets(Project project, String[] targetNames) throws BuildException {
 		Vector<String> v = new Vector<>();

ant/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote/EclipseSingleCheckExecutor.java

@@ -23,7 +23,6 @@
 
 public class EclipseSingleCheckExecutor extends SingleCheckExecutor {
 
-	@SuppressWarnings("unused")
 	@Override
 	public void executeTargets(Project project, String[] targetNames) throws BuildException {
 		Vector<String> v = new Vector<>();

ant/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote/InternalAntRunner.java

@@ -26,7 +26,6 @@
 import java.util.Collections;
 import java.util.Enumeration;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
@@ -114,7 +113,6 @@ public class InternalAntRunner {
 
 	private boolean scriptExecuted = false;
 
-	@SuppressWarnings("unused")
 	private final List<String> propertyFiles = new ArrayList<>();
 
 	/**
@@ -152,7 +150,6 @@ public static void main(String[] args) {
 	/*
 	 * Helper method to ensure an array is converted into an ArrayList.
 	 */
-	@SuppressWarnings("unused")
 	static ArrayList<String> getArrayList(String[] args) {
 		if (args == null) {
 			return null;
@@ -248,7 +245,6 @@ private void printArguments(Project project) {
 	 * @param project
 	 *            the project to list targets from
 	 */
-	@SuppressWarnings("unused")
 	private void printTargets(Project project) {
 		// notify the logger that project help message are coming
 		// since there is no buildstarted or targetstarted to
@@ -618,9 +614,7 @@ private void fireBuildFinished(Project project, Throwable error) {
 		if (!isVersionCompatible("1.5")) { //$NON-NLS-1$
 			BuildEvent event = new BuildEvent(project);
 			event.setException(error);
-			Iterator<BuildListener> iter = project.getBuildListeners().iterator();
-			while (iter.hasNext()) {
-				BuildListener listener = iter.next();
+			for (BuildListener listener : project.getBuildListeners()) {
 				listener.buildFinished(event);
 			}
 		} else {
@@ -790,7 +784,6 @@ private int parseInt(String value, String version) {
 		}
 	}
 
-	@SuppressWarnings("unused")
 	private boolean preprocessCommandLine(List<String> commands) {
 
 		String arg = getArgument(commands, "-listener"); //$NON-NLS-1$
@@ -953,7 +946,6 @@ private boolean processCommandLine(List<String> commands) {
 		return true;
 	}
 
-	@SuppressWarnings("unused")
 	private void processTasksAndTypes(List<String> commands) {
 		String arg = getArgument(commands, "-eclipseTask"); //$NON-NLS-1$
 		while (arg != null) {
@@ -1019,7 +1011,6 @@ private void processUnrecognizedCommands(List<String> commands) {
 	/*
 	 * Checks for targets specified at the command line.
 	 */
-	@SuppressWarnings("unused")
 	private void processTargets(List<String> commands) {
 		if (targets == null) {
 			targets = new Vector<>(commands.size());
@@ -1095,11 +1086,9 @@ private boolean processProperties(List<String> commands) {
 		return exceptionToBeThrown;
 	}
 
-	@SuppressWarnings("unused")
 	private void processMinusDProperties(List<String> commands) {
 		String[] args = commands.toArray(new String[commands.size()]);
-		for (int i = 0; i < args.length; i++) {
-			String arg = args[i];
+		for (String arg : args) {
 			if (arg.startsWith("-D")) { //$NON-NLS-1$
 				String name = arg.substring(2, arg.length());
 				String value = null;
@@ -1120,7 +1109,7 @@ private void processMinusDProperties(List<String> commands) {
 					userProperties = new HashMap<>();
 				}
 				userProperties.put(name, value);
-				commands.remove(args[i]);
+				commands.remove(arg);
 			}
 		}
 	}
@@ -1283,7 +1272,6 @@ private void setCurrentProject(Project currentProject) {
 	/**
 	 * Load all properties from the files specified by -propertyfile.
 	 */
-	@SuppressWarnings("unused")
 	private void loadPropertyFiles() {
 		for (String filename : propertyFiles) {
 			File file = getFileRelativeToBaseDir(filename);

ant/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote/logger/RemoteAntBuildLogger.java

@@ -236,7 +236,6 @@ protected void establishConnection() {
 		}
 	}
 
-	@SuppressWarnings("unused")
 	@Override
 	public void messageLogged(BuildEvent event) {
 		if (event.getPriority() > msgOutputLevel && event.getPriority() != InternalAntRunner.MSG_PROJECT_HELP) {

ant/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote/logger/RemoteAntDebugBuildLogger.java

@@ -332,7 +332,6 @@ protected void marshallProperties() {
 		sendRequestResponse(propertiesRepresentation.toString());
 	}
 
-	@SuppressWarnings("unused")
 	protected void addBreakpoint(String breakpointRepresentation) {
 		if (fBreakpoints == null) {
 			fBreakpoints = new ArrayList<>();