Skip to content

Commit 9171dc4

Browse files
committed
Convert ContentServlet to whiteboard
1 parent 07fd5ca commit 9171dc4

File tree

3 files changed

+9
-26
lines changed

3 files changed

+9
-26
lines changed

ua/org.eclipse.help.webapp/META-INF/MANIFEST.MF

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ Require-Bundle: org.eclipse.help.base;bundle-version="[4.3.200,5.0.0)",
1010
org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
1111
org.eclipse.equinox.jsp.jasper.registry;bundle-version="1.0.100",
1212
org.eclipse.jdt.core.compiler.batch;bundle-version="[3.33.0,4.0.0)"
13-
Service-Component: OSGI-INF/org.eclipse.help.internal.webapp.servlet.NavServlet.xml
13+
Service-Component: OSGI-INF/org.eclipse.help.internal.webapp.servlet.ContentServlet.xml,
14+
OSGI-INF/org.eclipse.help.internal.webapp.servlet.NavServlet.xml
1415
Export-Package: org.eclipse.help.internal.webapp;x-friends:="org.eclipse.ua.tests",
1516
org.eclipse.help.internal.webapp.data;x-friends:="org.eclipse.ua.tests",
1617
org.eclipse.help.internal.webapp.parser;x-internal:=true,

ua/org.eclipse.help.webapp/plugin.xml

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -52,31 +52,6 @@
5252
class="org.eclipse.help.internal.webapp.servlet.ControlServlet"
5353
httpcontextId="help">
5454
</servlet>
55-
<servlet
56-
alias="/content"
57-
class="org.eclipse.help.internal.webapp.servlet.ContentServlet"
58-
httpcontextId="help">
59-
</servlet>
60-
<servlet
61-
alias="/topic"
62-
class="org.eclipse.help.internal.webapp.servlet.ContentServlet"
63-
httpcontextId="help">
64-
</servlet>
65-
<servlet
66-
alias="/nftopic"
67-
class="org.eclipse.help.internal.webapp.servlet.ContentServlet"
68-
httpcontextId="help">
69-
</servlet>
70-
<servlet
71-
alias="/ntopic"
72-
class="org.eclipse.help.internal.webapp.servlet.ContentServlet"
73-
httpcontextId="help">
74-
</servlet>
75-
<servlet
76-
alias="/rtopic"
77-
class="org.eclipse.help.internal.webapp.servlet.ContentServlet"
78-
httpcontextId="help">
79-
</servlet>
8055
<servlet
8156
alias="/livehelp"
8257
class="org.eclipse.help.internal.webapp.servlet.LiveHelpServlet"

ua/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/ContentServlet.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,22 @@
1515

1616
import java.io.IOException;
1717

18+
import javax.servlet.Servlet;
1819
import javax.servlet.ServletException;
1920
import javax.servlet.http.HttpServlet;
2021
import javax.servlet.http.HttpServletRequest;
2122
import javax.servlet.http.HttpServletResponse;
2223

2324
import org.eclipse.help.internal.base.BaseHelpSystem;
25+
import org.osgi.service.component.annotations.Component;
26+
import org.osgi.service.http.whiteboard.propertytypes.HttpWhiteboardServletName;
27+
import org.osgi.service.http.whiteboard.propertytypes.HttpWhiteboardServletPattern;
2428
/**
2529
* Servlet to interface client with remote Eclipse
2630
*/
31+
@Component(service = Servlet.class)
32+
@HttpWhiteboardServletName("content")
33+
@HttpWhiteboardServletPattern({ "/content/*", "/topic/*", "/nftopic/*", "/ntopic/*", "/rtopic/*" })
2734
public class ContentServlet extends HttpServlet {
2835
private static final long serialVersionUID = 1L;
2936
private EclipseConnector connector;

0 commit comments

Comments
 (0)