[performance] do not normalize locations that are already normalized

When projects or links are added to the workspace the file location is
normalized and saved to disk. Good. However it is not needed to do that
for those already normalized paths that are loaded back from disk.

Saves some startup time on windows, where name capitalization of each
path segment is expensive IO.

Author: EcljpseB0T

resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.resources; singleton:=true
-Bundle-Version: 3.20.100.qualifier
+Bundle-Version: 3.20.200.qualifier
 Bundle-Activator: org.eclipse.core.resources.ResourcesPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/FileSystemResourceManager.java

@@ -660,9 +660,14 @@ public boolean hasSavedDescription(IProject project) {
 	 * @param location the File system location of this resource on disk
 	 * @return The file store for the provided resource
 	 */
-	private IFileStore initializeStore(IResource target, URI location) throws CoreException {
+	private IFileStore initializeStore(IResource target, URI location, boolean locationAlreadyNormalized)
+			throws CoreException {
 		ResourceInfo info = ((Resource) target).getResourceInfo(false, true);
-		setLocation(target, info, location);
+		if (locationAlreadyNormalized) {
+			setNormalizedLocation(target, info, location);
+		} else {
+			setLocation(target, info, location);
+		}
 		FileStoreRoot root = getStoreRoot(target);
 		return root.createStore(target.getFullPath(), target);
 	}
@@ -808,7 +813,7 @@ public boolean isLightweightAutoRefreshEnabled() {
 	}
 
 	public void link(Resource target, URI location, IFileInfo fileInfo) throws CoreException {
-		initializeStore(target, location);
+		initializeStore(target, location, false);
 		ResourceInfo info = target.getResourceInfo(false, true);
 		long lastModified = fileInfo == null ? 0 : fileInfo.getLastModified();
 		if (lastModified == 0)
@@ -928,7 +933,7 @@ public ProjectDescription read(IProject target, boolean creation) throws CoreExc
 			projectLocation = URIUtil.toURI(getProjectDefaultLocation(target));
 		}
 		IFile descFile = target.getFile(IProjectDescription.DESCRIPTION_FILE_NAME);
-		IFileStore projectStore = initializeStore(target, projectLocation);
+		IFileStore projectStore = initializeStore(target, projectLocation, true);
 		IFileStore descriptionStore = descFile.exists() ? getStore(descFile) : projectStore.getChild(IProjectDescription.DESCRIPTION_FILE_NAME);
 		ProjectDescription description = null;
 		//hold onto any exceptions until after sync info is updated, then throw it
@@ -1089,9 +1094,13 @@ public long setLocalTimeStamp(IResource target, ResourceInfo info, long value) t
 	 * @param location the new storage location
 	 */
 	public void setLocation(IResource target, ResourceInfo info, URI location) {
+		// Normalize case as it exists on the file system.
+		setNormalizedLocation(target, info, FileUtil.realURI(location));
+	}
+
+	public void setNormalizedLocation(IResource target, ResourceInfo info, URI location) {
 		FileStoreRoot oldRoot = info.getFileStoreRoot();
 		if (location != null) {
-			location = FileUtil.realURI(location); // Normalize case as it exists on the file system.
 			info.setFileStoreRoot(new FileStoreRoot(location, target.getFullPath()));
 		} else {
 			//project is in default location so clear the store root

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/Project.java

@@ -853,12 +853,21 @@ boolean internalHasBuildConfig(String configName) {
 	 * during workspace restore (i.e., when you cannot do an operation)
 	 */
 	void internalSetDescription(IProjectDescription value, boolean incrementContentId) {
+		internalSetDescription(value, incrementContentId, false);
+	}
+
+	void internalSetDescription(IProjectDescription value, boolean incrementContentId,
+			boolean locationAlreadyNormalized) {
 		// Project has been added / removed. Build order is out-of-step
 		workspace.flushBuildOrder();
 
 		ProjectInfo info = (ProjectInfo) getResourceInfo(false, true);
 		info.setDescription((ProjectDescription) value);
-		getLocalManager().setLocation(this, info, value.getLocationURI());
+		if (locationAlreadyNormalized) {
+			getLocalManager().setNormalizedLocation(this, info, value.getLocationURI());
+		} else {
+			getLocalManager().setLocation(this, info, value.getLocationURI());
+		}
 		if (incrementContentId) {
 			info.incrementContentId();
 			//if the project is not accessible, stamp will be null and should remain null

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/SaveManager.java

@@ -967,7 +967,7 @@ protected void restoreMetaInfo(Project project, IProgressMonitor monitor) throws
 			//try to read private metadata and add to the description
 			workspace.getMetaArea().readPrivateDescription(project, description);
 		}
-		project.internalSetDescription(description, false);
+		project.internalSetDescription(description, false, true);
 		if (failure != null) {
 			try {
 				// write the project tree ...