Perform clean code of team/bundles/org.eclipse.jsch.core

Author: eclipse-platform-bot

team/bundles/org.eclipse.jsch.core/src/org/eclipse/jsch/internal/core/JSchCorePlugin.java

@@ -128,8 +128,9 @@ public synchronized void setIdentityRepository(){
           break;
         }
       }
-      if(irepo!=null)
+      if(irepo!=null){
         break;
+      }
     }
 
     if(irepo!=null){
@@ -147,8 +148,9 @@ public IdentityRepository[] getPluggedInIdentityRepositries(){
     IExtension[] extensions=Platform.getExtensionRegistry().getExtensionPoint(
         JSchCorePlugin.ID, JSchCorePlugin.PT_IDENTITYREPOSITORY).getExtensions();
 
-    if(extensions.length==0)
+    if(extensions.length==0){
       return new IdentityRepository[0];
+    }
 
     ArrayList<IdentityRepository> tmp = new ArrayList<>();
     for(IExtension extension : extensions) {
@@ -189,8 +191,9 @@ public void loadKnownHosts(){
     Preferences preferences=JSchCorePlugin.getPlugin().getPluginPreferences();
     String ssh_home=preferences.getString(IConstants.KEY_SSH2HOME);
 
-    if(ssh_home.length()==0)
+    if(ssh_home.length()==0){
       ssh_home=PreferenceInitializer.SSH_HOME_DEFAULT;
+    }
 
     java.io.File file=new java.io.File(ssh_home, "known_hosts"); //$NON-NLS-1$
     try{

team/bundles/org.eclipse.jsch.core/src/org/eclipse/jsch/internal/core/JSchLocation.java

@@ -60,8 +60,9 @@ public int getPort(){
 
   @Override
   public void setUsername(String user){
-    if(userFixed)
+    if(userFixed){
       throw new UnsupportedOperationException();
+    }
     this.user=user;
   }
 
@@ -72,8 +73,9 @@ public String getUsername(){
 
   @Override
   public void setPassword(String password){
-    if(password!=null)
+    if(password!=null){
       this.password=password;
+    }
   }
 
   @Override

team/bundles/org.eclipse.jsch.core/src/org/eclipse/jsch/internal/core/JSchProvider.java

@@ -56,12 +56,14 @@ public Session createSession(IJSchLocation location, UserInfo uinfo) throws JSch
 
     if(uinfo==null){
       IUserAuthenticator authenticator=getPluggedInAuthenticator();
-      if(authenticator==null)
+      if(authenticator==null){
         authenticator=new NullUserAuthenticator();
+      }
       uinfo=new UserInfoImpl(location, authenticator, (JSchCorePlugin.getPlugin().getTimeout() * 1000));
     }
-    if(uinfo!=null)
+    if(uinfo!=null){
       session.setUserInfo(uinfo);
+    }
 
     return session;
   }
@@ -77,8 +79,9 @@ public void connect(Session session, int timeout,
 
     UserInfo ui=session.getUserInfo();
 
-    if(ui!=null && (ui instanceof UserInfoImpl))
+    if(ui!=null && (ui instanceof UserInfoImpl)){
       ((UserInfoImpl)ui).aboutToConnect();
+    }
 
     try{
       session.connect();
@@ -107,13 +110,15 @@ public void connect(Session session, int timeout,
         return;
       }
 
-      if(session.isConnected())
+      if(session.isConnected()){
         session.disconnect();
+      }
       throw e;
     }
 
-    if(ui!=null && (ui instanceof UserInfoImpl))
+    if(ui!=null && (ui instanceof UserInfoImpl)){
       ((UserInfoImpl)ui).connectionMade();
+    }
   }
 
   @Override
@@ -122,8 +127,9 @@ public Proxy getProxyForHost(String host, String proxyType) {
   }
 
   public static IJSchService getInstance(){
-    if (instance == null)
+    if (instance == null){
       instance = new JSchProvider();
+    }
     return instance;
   }
 
@@ -149,8 +155,9 @@ public void connect(Proxy proxy, String host, int port, int timeout,
   private IUserAuthenticator getPluggedInAuthenticator(){
     IExtension[] extensions=Platform.getExtensionRegistry().getExtensionPoint(
         JSchCorePlugin.ID, JSchCorePlugin.PT_AUTHENTICATOR).getExtensions();
-    if(extensions.length==0)
+    if(extensions.length==0){
       return null;
+    }
     IExtension extension=extensions[0];
     IConfigurationElement[] configs=extension.getConfigurationElements();
     if(configs.length==0){
@@ -187,8 +194,9 @@ private boolean isAuthenticationFailure(JSchException ee){
   }
 
   private boolean hasPromptExceededTimeout(Session session){
-    if(session.getUserInfo()==null || !(session.getUserInfo() instanceof UserInfoImpl))
+    if(session.getUserInfo()==null || !(session.getUserInfo() instanceof UserInfoImpl)){
       return false;
+    }
     return ((UserInfoImpl)session.getUserInfo()).hasPromptExceededTimeout();
   }
 

team/bundles/org.eclipse.jsch.core/src/org/eclipse/jsch/internal/core/Policy.java

@@ -18,22 +18,26 @@
 public class Policy{
 
   public static void checkCanceled(IProgressMonitor monitor){
-    if(monitor.isCanceled())
+    if(monitor.isCanceled()){
       throw new OperationCanceledException();
+    }
   }
 
   public static IProgressMonitor monitorFor(IProgressMonitor monitor){
-    if(monitor==null)
+    if(monitor==null){
       return new NullProgressMonitor();
+    }
     return monitor;
   }
 
   public static IProgressMonitor subMonitorFor(IProgressMonitor monitor,
       int ticks){
-    if(monitor==null)
+    if(monitor==null){
       return new NullProgressMonitor();
-    if(monitor instanceof NullProgressMonitor)
+    }
+    if(monitor instanceof NullProgressMonitor){
       return monitor;
+    }
     return SubMonitor.convert(monitor, ticks);
   }
 

team/bundles/org.eclipse.jsch.core/src/org/eclipse/jsch/internal/core/PreferenceInitializer.java

@@ -45,16 +45,18 @@ public class PreferenceInitializer extends AbstractPreferenceInitializer{
   public void initializeDefaultPreferences(){
     IEclipsePreferences defaultNode=DefaultScope.INSTANCE
         .getNode(JSchCorePlugin.ID);
-    if(SSH_HOME_DEFAULT!=null)
+    if(SSH_HOME_DEFAULT!=null){
       defaultNode.put(IConstants.KEY_SSH2HOME, SSH_HOME_DEFAULT);
+    }
     defaultNode.put(IConstants.KEY_PRIVATEKEY, IConstants.PRIVATE_KEYS_DEFAULT);
     changeDefaultWin32SshHome();
     Utils.migrateSSH2Preferences();
   }
 
   private void changeDefaultWin32SshHome(){
-    if(!Platform.getOS().equals(Platform.OS_WIN32))
+    if(!Platform.getOS().equals(Platform.OS_WIN32)){
       return;
+    }
 
     IEclipsePreferences preferences=InstanceScope.INSTANCE
         .getNode(JSchCorePlugin.ID);
@@ -72,9 +74,10 @@ private void changeDefaultWin32SshHome(){
         if(SSH_OLD_WIN32_HOME_DEFAULT!=null
             &&new File(SSH_OLD_WIN32_HOME_DEFAULT).exists()){
           if(!(SSH_HOME_DEFAULT!=null&&new File(SSH_HOME_DEFAULT).exists())
-              ||existingWorkspace)
+              ||existingWorkspace){
             preferences
                 .put(IConstants.KEY_SSH2HOME, SSH_OLD_WIN32_HOME_DEFAULT);
+          }
         }
       }
 

team/bundles/org.eclipse.jsch.core/src/org/eclipse/jsch/internal/core/ResponsiveSocketFactory.java

@@ -41,21 +41,24 @@ public class ResponsiveSocketFactory implements SocketFactory {
   private static Class<?> proxyClass;
   private static boolean hasProxyClass = true;
   public ResponsiveSocketFactory(IProgressMonitor monitor, int timeout) {
-    if (monitor == null)
+    if (monitor == null){
       monitor = new NullProgressMonitor();
+    }
     this.monitor = monitor;
     this.timeout=timeout;
   }
   @Override
   public InputStream getInputStream(Socket socket) throws IOException {
-    if (in == null)
+    if (in == null){
       in = socket.getInputStream();
+    }
     return in;
   }
   @Override
   public OutputStream getOutputStream(Socket socket) throws IOException {
-    if (out == null)
+    if (out == null){
       out = socket.getOutputStream();
+    }
     return out;
   }
   @Override
@@ -101,7 +104,9 @@ private Socket createSocket(final String host, final int port, int timeout, IPro
     thread.start();
 
     // Wait the appropriate number of seconds
-    if (timeout == 0) timeout = DEFAULT_TIMEOUT;
+    if (timeout == 0){
+      timeout = DEFAULT_TIMEOUT;
+    }
     for (int i = 0; i < timeout; i++) {
       try {
         // wait for the thread to complete or 1 second, which ever comes first
@@ -131,10 +136,12 @@ private Socket createSocket(final String host, final int port, int timeout, IPro
       }
     }
     if (exception[0] != null) {
-      if (exception[0] instanceof UnknownHostException)
+      if (exception[0] instanceof UnknownHostException){
         throw (UnknownHostException)exception[0];
-      else
+      }
+      else{
         throw (IOException)exception[0];
+      }
     }
     if (socket[0] == null) {
       throw new InterruptedIOException(NLS.bind(Messages.Util_timeout, host));
@@ -154,8 +161,7 @@ private Socket createSocket(final String host, final int port, int timeout, IPro
         Object noProxyObject = field.get(null);
         Constructor<Socket> constructor = Socket.class.getConstructor(proxyClass);
         Object o = constructor.newInstance(noProxyObject);
-        if(o instanceof Socket){
-          Socket socket=(Socket)o;
+        if(o instanceof Socket socket){
           socket.connect(new InetSocketAddress(host, port), timeout * 1000);
           return socket;
         }

team/bundles/org.eclipse.jsch.core/src/org/eclipse/jsch/internal/core/UserInfoImpl.java

@@ -131,8 +131,9 @@ public boolean promptPassword(String message){
       if(_password!=null){
         password=_password;
         // Cache the password with the repository location on the memory.
-        if(location!=null)
+        if(location!=null){
           location.setPassword(password);
+        }
       }
       return _password!=null;
     }
@@ -166,8 +167,9 @@ public String[] promptKeyboardInteractive(String destination, String name,
       }
       String[] result=authenticator.promptForKeyboradInteractive(location,
           destination, name, instruction, prompt, echo);
-      if(result==null)
+      if(result==null){
         return null; // canceled
+      }
       if(result.length==1&&prompt.length==1
           &&prompt[0].trim().equalsIgnoreCase("password:")){ //$NON-NLS-1$
         password=result[0];