Use Win32Handler native file-system handler by default on Windows

This is done in preparation for the removal of the JNI based native
LocalFileHandler for Windows. This increases the number of users (and
therefore testers) but still makes it easily possible to revert to the
old implementation if regressions are found.

Author: HannesWell

resources/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/local/LocalFileNativesManager.java

@@ -28,16 +28,16 @@
  * <p>Dispatches methods backed by native code to the appropriate platform specific
  * implementation depending on a library provided by a fragment. Failing this it tries
  * to use Java 7 NIO/2 API's.</p>
- * 
- * <p>Use of native libraries can be disabled by adding -Declipse.filesystem.useNatives=false 
+ *
+ * <p>Use of native libraries can be disabled by adding -Declipse.filesystem.useNatives=false
  * to VM arguments.</p>
- * 
+ *
  * <p>Please notice that the native implementation is significantly faster than the non-native
- * one. The BenchFileStore test runs 3.1 times faster on Linux with the native code than 
+ * one. The BenchFileStore test runs 3.1 times faster on Linux with the native code than
  * without it.</p>
  */
 public class LocalFileNativesManager {
-	public static final boolean PROPERTY_USE_NATIVE_DEFAULT = true;
+	public static final boolean PROPERTY_USE_NATIVE_DEFAULT = Platform.OS.isWindows() ? false : true;
 	public static final String PROPERTY_USE_NATIVES = "eclipse.filesystem.useNatives"; //$NON-NLS-1$
 	private static NativeHandler HANDLER;
 
@@ -54,7 +54,7 @@ public static void reset() {
 
 	/**
 	 * Try to set the usage of natives to the provided value
-	 * @return <code>true</code> if natives are used as result of this call <code>false</code> otherwhise
+	 * @return <code>true</code> if natives are used as result of this call <code>false</code> otherwise
 	 */
 	public static boolean setUsingNative(boolean useNatives) {
 		boolean nativesAreUsed;

resources/tests/org.eclipse.core.tests.filesystem.feature/feature.xml

@@ -25,12 +25,6 @@
          arch="x86_64"
          version="0.0.0"/>
 
-   <plugin
-         id="org.eclipse.core.filesystem.win32.x86_64"
-         os="win32"
-         arch="x86_64"
-         version="0.0.0"/>
-
    <plugin
          id="org.eclipse.core.filesystem.macosx"
          os="macosx"

resources/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/regression/Bug_530868.java

@@ -16,7 +16,6 @@
 import static org.eclipse.core.resources.ResourcesPlugin.getWorkspace;
 import static org.eclipse.core.tests.resources.ResourceTestUtil.createTestMonitor;
 import static org.junit.Assert.assertNotEquals;
-import static org.junit.Assert.assertTrue;
 import static org.junit.Assume.assumeFalse;
 
 import java.io.ByteArrayInputStream;
@@ -64,8 +63,6 @@ public void setUp() throws Exception {
 	public void testMillisecondResolution() throws Exception {
 		assumeFalse("not relevant on Mac, as it does not have milliseconds resolution", OS.isMac());
 		try {
-			assertTrue("can only run if native provider can be enabled", LocalFileNativesManager.setUsingNative(true));
-
 			/*
 			 * Run 3 times in case we have seconds resolution due to a bug, but by chance we
 			 * happened to modify the file in-between two seconds.