Skip to content

Commit bec1cf2

Browse files
EcljpseB0Tjukzi
authored andcommitted
Disable some ecj warnings especially in examples and tests
To reduce warnings in workspace potentiallyUnclosedCloseable=ignore discouragedReference=ignore parameterAssignment=ignore autoboxing=ignore Those are no real problem and ignored by the developers for years
1 parent fe711da commit bec1cf2

File tree

15 files changed

+64
-13
lines changed

15 files changed

+64
-13
lines changed

ant/org.eclipse.ant.tests.core/test support/org/eclipse/ant/tests/core/support/testloggers/TestBuildLogger.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ public void setMessageOutputLevel(int level) {
4242
fMessageOutputLevel = level;
4343
}
4444

45+
@Override
4546
public int getMessageOutputLevel() {
4647
return fMessageOutputLevel;
4748
}

debug/org.eclipse.debug.examples.core/.settings/org.eclipse.jdt.core.prefs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
eclipse.preferences.version=1
2+
org.eclipse.jdt.core.builder.annotationPath.allLocations=disabled
23
org.eclipse.jdt.core.builder.cleanOutputFolder=clean
34
org.eclipse.jdt.core.builder.duplicateResourceTask=warning
45
org.eclipse.jdt.core.builder.invalidClasspath=abort
@@ -28,6 +29,7 @@ org.eclipse.jdt.core.compiler.debug.sourceFile=generate
2829
org.eclipse.jdt.core.compiler.doc.comment.support=enabled
2930
org.eclipse.jdt.core.compiler.maxProblemPerUnit=100
3031
org.eclipse.jdt.core.compiler.problem.APILeak=warning
32+
org.eclipse.jdt.core.compiler.problem.annotatedTypeArgumentToUnannotated=info
3133
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
3234
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
3335
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
@@ -89,7 +91,7 @@ org.eclipse.jdt.core.compiler.problem.parameterAssignment=warning
8991
org.eclipse.jdt.core.compiler.problem.pessimisticNullAnalysisForFreeTypeVariables=warning
9092
org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=warning
9193
org.eclipse.jdt.core.compiler.problem.potentialNullReference=warning
92-
org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=warning
94+
org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore
9395
org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning
9496
org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=warning
9597
org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore
@@ -102,6 +104,7 @@ org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
102104
org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
103105
org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=enabled
104106
org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
107+
org.eclipse.jdt.core.compiler.problem.suppressWarningsNotFullyAnalysed=ignore
105108
org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
106109
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
107110
org.eclipse.jdt.core.compiler.problem.terminalDeprecation=warning
@@ -118,6 +121,7 @@ org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
118121
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error
119122
org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
120123
org.eclipse.jdt.core.compiler.problem.unsafeTypeOperation=warning
124+
org.eclipse.jdt.core.compiler.problem.unstableAutoModuleName=warning
121125
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=warning
122126
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled
123127
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled

debug/org.eclipse.debug.examples.ui/.settings/org.eclipse.jdt.core.prefs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
eclipse.preferences.version=1
2+
org.eclipse.jdt.core.builder.annotationPath.allLocations=disabled
23
org.eclipse.jdt.core.builder.cleanOutputFolder=clean
34
org.eclipse.jdt.core.builder.duplicateResourceTask=warning
45
org.eclipse.jdt.core.builder.invalidClasspath=abort
@@ -28,6 +29,7 @@ org.eclipse.jdt.core.compiler.debug.sourceFile=generate
2829
org.eclipse.jdt.core.compiler.doc.comment.support=enabled
2930
org.eclipse.jdt.core.compiler.maxProblemPerUnit=100
3031
org.eclipse.jdt.core.compiler.problem.APILeak=warning
32+
org.eclipse.jdt.core.compiler.problem.annotatedTypeArgumentToUnannotated=info
3133
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
3234
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
3335
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
@@ -89,7 +91,7 @@ org.eclipse.jdt.core.compiler.problem.parameterAssignment=warning
8991
org.eclipse.jdt.core.compiler.problem.pessimisticNullAnalysisForFreeTypeVariables=warning
9092
org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=warning
9193
org.eclipse.jdt.core.compiler.problem.potentialNullReference=warning
92-
org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=warning
94+
org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore
9395
org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning
9496
org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=warning
9597
org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore
@@ -102,6 +104,7 @@ org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
102104
org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
103105
org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=enabled
104106
org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
107+
org.eclipse.jdt.core.compiler.problem.suppressWarningsNotFullyAnalysed=ignore
105108
org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
106109
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
107110
org.eclipse.jdt.core.compiler.problem.terminalDeprecation=warning
@@ -118,6 +121,7 @@ org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
118121
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error
119122
org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
120123
org.eclipse.jdt.core.compiler.problem.unsafeTypeOperation=warning
124+
org.eclipse.jdt.core.compiler.problem.unstableAutoModuleName=warning
121125
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=warning
122126
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled
123127
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled

debug/org.eclipse.debug.tests/.settings/org.eclipse.jdt.core.prefs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
eclipse.preferences.version=1
2+
org.eclipse.jdt.core.builder.annotationPath.allLocations=disabled
23
org.eclipse.jdt.core.builder.cleanOutputFolder=clean
34
org.eclipse.jdt.core.builder.duplicateResourceTask=warning
45
org.eclipse.jdt.core.builder.invalidClasspath=abort
@@ -28,6 +29,7 @@ org.eclipse.jdt.core.compiler.debug.sourceFile=generate
2829
org.eclipse.jdt.core.compiler.doc.comment.support=enabled
2930
org.eclipse.jdt.core.compiler.maxProblemPerUnit=100
3031
org.eclipse.jdt.core.compiler.problem.APILeak=warning
32+
org.eclipse.jdt.core.compiler.problem.annotatedTypeArgumentToUnannotated=info
3133
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
3234
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
3335
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
@@ -36,7 +38,7 @@ org.eclipse.jdt.core.compiler.problem.deadCode=warning
3638
org.eclipse.jdt.core.compiler.problem.deprecation=warning
3739
org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
3840
org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
39-
org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
41+
org.eclipse.jdt.core.compiler.problem.discouragedReference=ignore
4042
org.eclipse.jdt.core.compiler.problem.emptyStatement=warning
4143
org.eclipse.jdt.core.compiler.problem.enablePreviewFeatures=disabled
4244
org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
@@ -102,6 +104,7 @@ org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
102104
org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
103105
org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=enabled
104106
org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
107+
org.eclipse.jdt.core.compiler.problem.suppressWarningsNotFullyAnalysed=ignore
105108
org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
106109
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
107110
org.eclipse.jdt.core.compiler.problem.terminalDeprecation=warning
@@ -118,6 +121,7 @@ org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
118121
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error
119122
org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
120123
org.eclipse.jdt.core.compiler.problem.unsafeTypeOperation=warning
124+
org.eclipse.jdt.core.compiler.problem.unstableAutoModuleName=warning
121125
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=warning
122126
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled
123127
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled

debug/org.eclipse.debug.ui.launchview.tests/.settings/org.eclipse.jdt.core.prefs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
eclipse.preferences.version=1
2+
org.eclipse.jdt.core.builder.annotationPath.allLocations=disabled
23
org.eclipse.jdt.core.builder.cleanOutputFolder=clean
34
org.eclipse.jdt.core.builder.duplicateResourceTask=warning
45
org.eclipse.jdt.core.builder.invalidClasspath=abort
@@ -28,6 +29,7 @@ org.eclipse.jdt.core.compiler.debug.sourceFile=generate
2829
org.eclipse.jdt.core.compiler.doc.comment.support=enabled
2930
org.eclipse.jdt.core.compiler.maxProblemPerUnit=100
3031
org.eclipse.jdt.core.compiler.problem.APILeak=warning
32+
org.eclipse.jdt.core.compiler.problem.annotatedTypeArgumentToUnannotated=info
3133
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
3234
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
3335
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
@@ -84,7 +86,7 @@ org.eclipse.jdt.core.compiler.problem.nullReference=error
8486
org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error
8587
org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=warning
8688
org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning
87-
org.eclipse.jdt.core.compiler.problem.parameterAssignment=warning
89+
org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
8890
org.eclipse.jdt.core.compiler.problem.pessimisticNullAnalysisForFreeTypeVariables=warning
8991
org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=warning
9092
org.eclipse.jdt.core.compiler.problem.potentialNullReference=warning
@@ -100,6 +102,7 @@ org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
100102
org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
101103
org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=enabled
102104
org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
105+
org.eclipse.jdt.core.compiler.problem.suppressWarningsNotFullyAnalysed=info
103106
org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
104107
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
105108
org.eclipse.jdt.core.compiler.problem.terminalDeprecation=warning
@@ -116,6 +119,7 @@ org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
116119
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error
117120
org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
118121
org.eclipse.jdt.core.compiler.problem.unsafeTypeOperation=warning
122+
org.eclipse.jdt.core.compiler.problem.unstableAutoModuleName=warning
119123
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=warning
120124
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled
121125
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled

debug/org.eclipse.debug.ui/.settings/org.eclipse.jdt.core.prefs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ org.eclipse.jdt.core.compiler.problem.nullReference=error
8787
org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error
8888
org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=warning
8989
org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning
90-
org.eclipse.jdt.core.compiler.problem.parameterAssignment=warning
90+
org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
9191
org.eclipse.jdt.core.compiler.problem.pessimisticNullAnalysisForFreeTypeVariables=warning
9292
org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=warning
9393
org.eclipse.jdt.core.compiler.problem.potentialNullReference=warning

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ansi/preferences/AnsiConsolePreferencePage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public boolean performOk() {
107107
IHandlerService handlerService = PlatformUI.getWorkbench().getService(IHandlerService.class);
108108
try {
109109
handlerService.executeCommand(EnableDisableHandler.COMMAND_ID, new Event());
110-
} catch (@SuppressWarnings("unused") Exception ex) {
110+
} catch (Exception ex) {
111111
System.out.println("AnsiConsole: Command '" + EnableDisableHandler.COMMAND_ID + "' not found"); //$NON-NLS-1$ //$NON-NLS-2$
112112
}
113113
return result;

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ansi/preferences/AnsiConsolePreferenceUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public static int tryParseInteger(String text) {
9595

9696
try {
9797
return Integer.parseInt(text);
98-
} catch (@SuppressWarnings("unused") NumberFormatException e) {
98+
} catch (NumberFormatException e) {
9999
return -1;
100100
}
101101
}

debug/org.eclipse.unittest.ui/.settings/org.eclipse.jdt.core.prefs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
eclipse.preferences.version=1
2+
org.eclipse.jdt.core.builder.annotationPath.allLocations=disabled
23
org.eclipse.jdt.core.builder.cleanOutputFolder=clean
34
org.eclipse.jdt.core.builder.duplicateResourceTask=warning
45
org.eclipse.jdt.core.builder.invalidClasspath=abort
@@ -41,7 +42,7 @@ org.eclipse.jdt.core.compiler.problem.APILeak=warning
4142
org.eclipse.jdt.core.compiler.problem.annotatedTypeArgumentToUnannotated=info
4243
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
4344
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
44-
org.eclipse.jdt.core.compiler.problem.autoboxing=info
45+
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
4546
org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning
4647
org.eclipse.jdt.core.compiler.problem.deadCode=error
4748
org.eclipse.jdt.core.compiler.problem.deprecation=warning

debug/org.eclipse.unittest.ui/src/org/eclipse/unittest/internal/ui/TestRunnerViewPart.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,26 +286,32 @@ public enum TestResultsLayout {
286286
private final IPartListener2 fPartListener = new IPartListener2() {
287287
@Override
288288
public void partActivated(IWorkbenchPartReference ref) {
289+
// do nothing
289290
}
290291

291292
@Override
292293
public void partBroughtToTop(IWorkbenchPartReference ref) {
294+
// do nothing
293295
}
294296

295297
@Override
296298
public void partInputChanged(IWorkbenchPartReference ref) {
299+
// do nothing
297300
}
298301

299302
@Override
300303
public void partClosed(IWorkbenchPartReference ref) {
304+
// do nothing
301305
}
302306

303307
@Override
304308
public void partDeactivated(IWorkbenchPartReference ref) {
309+
// do nothing
305310
}
306311

307312
@Override
308313
public void partOpened(IWorkbenchPartReference ref) {
314+
// do nothing
309315
}
310316

311317
@Override
@@ -1321,6 +1327,7 @@ protected Point computeSize(Composite composite, int wHint, int hHint, boolean f
13211327

13221328
@Override
13231329
protected void layout(Composite composite, boolean flushCache) {
1330+
// do nothing
13241331
}
13251332
});
13261333
top.setTopLeft(empty); // makes ViewForm draw the horizontal separator line ...

0 commit comments

Comments
 (0)