Skip to content

Commit c4f1ff2

Browse files
committed
Dispose font in TerminalColorsFieldEditor
TerminalColorsFieldEditor had a dispose method, but FieldEditorPreferencePage does not call dispose on the individual field editors despite API implication that it should. Change-Id: I98c2987446d8b005cbca571763a9e811e966e0d3
1 parent 1a153e8 commit c4f1ff2

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/preferences/TerminalPreferencePage.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@
3737
*/
3838
public class TerminalPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage {
3939

40+
private TerminalColorsFieldEditor terminalColorsFieldEditor;
41+
4042
public TerminalPreferencePage() {
4143
super(GRID);
4244
}
@@ -72,6 +74,16 @@ protected void setupEditors() {
7274
addField(new IntegerFieldEditor(ITerminalConstants.PREF_BUFFERLINES, TerminalMessages.BUFFERLINES,
7375
getFieldEditorParent()));
7476

75-
addField(new TerminalColorsFieldEditor(getFieldEditorParent()));
77+
terminalColorsFieldEditor = new TerminalColorsFieldEditor(getFieldEditorParent());
78+
addField(terminalColorsFieldEditor);
79+
}
80+
81+
@Override
82+
public void dispose() {
83+
if (terminalColorsFieldEditor != null) {
84+
terminalColorsFieldEditor.dispose();
85+
}
86+
87+
super.dispose();
7688
}
7789
}

0 commit comments

Comments
 (0)