Fix compiler warnings

Author: laeubi

terminal/plugins/org.eclipse.tm.terminal.connector.ssh/src/org/eclipse/tm/terminal/connector/ssh/activator/UIPlugin.java

@@ -31,7 +31,7 @@ public class UIPlugin extends AbstractUIPlugin {
 	private static volatile TraceHandler traceHandler;
 
 	// ServiceTracker for IJschService
-	private ServiceTracker tracker;
+	private ServiceTracker<IJSchService, IJSchService> tracker;
 
 	/**
 	 * The constructor
@@ -77,13 +77,12 @@ public static TraceHandler getTraceHandler() {
 	/* (non-Javadoc)
 	 * @see org.eclipse.ui.plugin.AbstractUIPlugin#start(org.osgi.framework.BundleContext)
 	 */
-	@SuppressWarnings("unchecked")
 	@Override
 	public void start(BundleContext context) throws Exception {
 		super.start(context);
 		plugin = this;
 
-		tracker = new ServiceTracker(getBundle().getBundleContext(), IJSchService.class.getName(), null);
+		tracker = new ServiceTracker<>(getBundle().getBundleContext(), IJSchService.class.getName(), null);
 		tracker.open();
 	}
 
@@ -107,7 +106,7 @@ public void stop(BundleContext context) throws Exception {
 	 * 		IJschService service is available.
 	 */
 	public IJSchService getJSchService() {
-		return (IJSchService) tracker.getService();
+		return tracker.getService();
 	}
 
 	//---------------------------------------------------------------------------

terminal/plugins/org.eclipse.tm.terminal.connector.ssh/src/org/eclipse/tm/terminal/connector/ssh/connector/KeyboardInteractiveDialog.java

@@ -134,7 +134,6 @@ protected Control createDialogArea(Composite parent) {
 	 *
 	 * @param parent  the parent of the widgets
 	 */
-	@SuppressWarnings("unused")
 	protected void createPasswordFields(Composite parent) {
 		texts = new Text[prompt.length];
 

terminal/plugins/org.eclipse.tm.terminal.connector.ssh/src/org/eclipse/tm/terminal/connector/ssh/controls/SshWizardConfigurationPanel.java

@@ -217,7 +217,7 @@ protected void fillSettingsForHost(String host) {
 					sshSettings.setUser(hostSettings.get(ITerminalsConnectorConstants.PROP_SSH_USER));
 				}
 				if (hostSettings.get(SAVE_PASSWORD) != null) {
-					savePassword = new Boolean(hostSettings.get(SAVE_PASSWORD)).booleanValue();
+					savePassword = Boolean.parseBoolean(hostSettings.get(SAVE_PASSWORD));
 				}
 				if (!savePassword) {
 					sshSettings.setPassword(""); //$NON-NLS-1$

terminal/plugins/org.eclipse.tm.terminal.connector.ssh/src/org/eclipse/tm/terminal/connector/ssh/launcher/SshLauncherDelegate.java

@@ -121,9 +121,9 @@ private String getTerminalTitle(Map<String, Object> properties) {
 	 * @see org.eclipse.core.runtime.PlatformObject#getAdapter(java.lang.Class)
 	 */
 	@Override
-	public Object getAdapter(Class adapter) {
+	public <T> T getAdapter(Class<T> adapter) {
 		if (IMementoHandler.class.equals(adapter)) {
-			return mementoHandler;
+			return adapter.cast(mementoHandler);
 		}
 		return super.getAdapter(adapter);
 	}