Perform clean code of terminal/bundles/org.eclipse.terminal.view.ui

Author: eclipse-platform-bot

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/actions/InvertColorsAction.java

@@ -41,8 +41,9 @@ public InvertColorsAction(TabFolderManager tabFolderManager) {
 	@Override
 	public void run() {
 		ITerminalViewControl target = getTarget();
-		if (target == null)
+		if (target == null) {
 			return;
+		}
 		target.setInvertedColors(!target.isInvertedColors());
 	}
 

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/actions/RenameTerminalAction.java

@@ -42,8 +42,9 @@ public RenameTerminalAction(TabFolderManager tabFolderManager) {
 	@Override
 	public void run() {
 		ITerminalViewControl target = getTarget();
-		if (target == null)
+		if (target == null) {
 			return;
+		}
 		InputDialog inputDialog = new InputDialog(target.getControl().getShell(), //
 				Messages.RenameTerminalAction_inputdialog_title, //
 				Messages.RenameTerminalAction_inputdialog_prompt, //

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/actions/SelectEncodingAction.java

@@ -47,8 +47,9 @@ public SelectEncodingAction(TabFolderManager tabFolderManager) {
 	@Override
 	public void run() {
 		ITerminalViewControl target = getTarget();
-		if (target == null)
+		if (target == null) {
 			return;
+		}
 
 		EncodingSelectionDialog dialog = new EncodingSelectionDialog(null);
 		dialog.setCharset(target.getCharset());

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/activator/UIPlugin.java

@@ -143,8 +143,9 @@ public boolean preShutdown(IWorkbench workbench, boolean forced) {
 								// Loop the tab items and find the still connected ones
 								for (CTabItem item : items) {
 									// Ignore disposed items
-									if (item.isDisposed())
+									if (item.isDisposed()) {
 										continue;
+									}
 									// Get the terminal view control
 									ITerminalViewControl terminal = (ITerminalViewControl) item.getData();
 									if (terminal == null || terminal.getState() != TerminalState.CONNECTED) {
@@ -158,8 +159,9 @@ public boolean preShutdown(IWorkbench workbench, boolean forced) {
 							// Push the determined saveable items to the memento handler
 							TerminalsViewMementoHandler mementoHandler = ((TerminalsView) part)
 									.getAdapter(TerminalsViewMementoHandler.class);
-							if (mementoHandler != null)
+							if (mementoHandler != null) {
 								mementoHandler.setSaveables(saveables);
+							}
 						}
 					}
 				}
@@ -183,8 +185,9 @@ public void postShutdown(IWorkbench workbench) {
 	void activateContexts() {
 		if (Display.getCurrent() != null) {
 			IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
-			if (window != null && windowListener != null)
+			if (window != null && windowListener != null) {
 				windowListener.windowOpened(window);
+			}
 		} else {
 			PlatformUI.getWorkbench().getDisplay().asyncExec(() -> activateContexts());
 		}
@@ -267,8 +270,9 @@ public static void log(IStatus status) {
 
 	public static boolean isOptionEnabled(String strOption) {
 		String strEnabled = Platform.getDebugOption(strOption);
-		if (strEnabled == null)
+		if (strEnabled == null) {
 			return false;
+		}
 
 		return Boolean.parseBoolean(strEnabled);
 	}

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/controls/ConfigurationPanelControl.java

@@ -145,8 +145,9 @@ public void setupPanel(Composite parent, String[] configurationPanelKeys) {
 
 		if (isPanelIsGroup()) {
 			panel = new Group(parent, SWT.NONE);
-			if (getGroupLabel() != null)
+			if (getGroupLabel() != null) {
 				((Group) panel).setText(getGroupLabel());
+			}
 		} else {
 			panel = new Composite(parent, SWT.NONE);
 		}
@@ -208,8 +209,9 @@ public final boolean isEmptyConfigurationPanel(IConfigurationPanel panel) {
 	 * @param panel The configuration panel instance or <code>null</code>.
 	 */
 	public void addConfigurationPanel(String key, IConfigurationPanel panel) {
-		if (key == null)
+		if (key == null) {
 			return;
+		}
 		if (panel != null) {
 			configurationPanels.put(key, panel);
 		} else {
@@ -252,17 +254,19 @@ public void showConfigurationPanel(String key) {
 		}
 		IConfigurationPanel configPanel = getActiveConfigurationPanel();
 		Map<String, Object> data = new HashMap<>();
-		if (configPanel != null)
+		if (configPanel != null) {
 			configPanel.extractData(data);
+		}
 		configPanel = getConfigurationPanel(key);
 		Assert.isNotNull(configPanel);
 		if (configPanel.getControl() != null) {
 			activeConfigurationPanel = configPanel;
 			activeConfigurationPanelKey = key;
 			panelLayout.topControl = configPanel.getControl();
 			panel.layout();
-			if (!data.isEmpty())
+			if (!data.isEmpty()) {
 				configPanel.updateData(data);
+			}
 			configPanel.activate();
 		} else {
 			activeConfigurationPanelKey = key;
@@ -343,8 +347,9 @@ public void doRestoreWidgetValues(IDialogSettings settings, String idPrefix) {
 			IConfigurationPanel configPanel = getConfigurationPanel(panelKey);
 			if (configPanel != null && !isEmptyConfigurationPanel(configPanel)) {
 				IDialogSettings configPanelSettings = settings.getSection(panelKey);
-				if (configPanelSettings == null)
+				if (configPanelSettings == null) {
 					configPanelSettings = settings.addNewSection(panelKey);
+				}
 				configPanel.doRestoreWidgetValues(configPanelSettings, idPrefix);
 			}
 		}
@@ -383,8 +388,9 @@ public void doSaveWidgetValues(IDialogSettings settings, String idPrefix) {
 		if (configPanel != null && !isEmptyConfigurationPanel(configPanel)) {
 			String key = getActiveConfigurationPanelKey();
 			IDialogSettings configPanelSettings = settings.getSection(key);
-			if (configPanelSettings == null)
+			if (configPanelSettings == null) {
 				configPanelSettings = settings.addNewSection(key);
+			}
 			configPanel.doSaveWidgetValues(configPanelSettings, idPrefix);
 		}
 	}

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/ExternalExecutablesState.java

@@ -23,7 +23,7 @@
  */
 public class ExternalExecutablesState extends AbstractSourceProvider {
 	public final static String CONFIGURED_STATE = "org.eclipse.terminal.external.executable.configured"; //$NON-NLS-1$
-	private boolean enabled;
+	private final boolean enabled;
 
 	public ExternalExecutablesState() {
 		this.enabled = ExternalExecutablesManager.hasEntries();

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/PropertyTester.java

@@ -29,7 +29,7 @@ public class PropertyTester extends org.eclipse.core.expressions.PropertyTester
 	public boolean test(Object receiver, String property, Object[] args, Object expectedValue) {
 
 		if ("hasApplicableLauncherDelegates".equals(property)) { //$NON-NLS-1$
-			ISelection selection = receiver instanceof ISelection ? (ISelection) receiver
+			ISelection selection = receiver instanceof ISelection i ? i
 					: new StructuredSelection(receiver);
 			return expectedValue.equals(Boolean.valueOf(
 					LauncherDelegateManager.getInstance().getApplicableLauncherDelegates(selection).length > 0));

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/SettingsStore.java

@@ -52,9 +52,10 @@ public final String get(String key) {
 	@Override
 	public final void put(String key, String value) {
 		Assert.isNotNull(key);
-		if (value == null)
+		if (value == null) {
 			settings.remove(key);
-		else
+		} else {
 			settings.put(key, value);
+		}
 	}
 }

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/dialogs/EncodingSelectionDialog.java

@@ -184,8 +184,9 @@ public void setDialogTitle(String title) {
 	@Override
 	protected void okPressed() {
 		// Save the selected encoding
-		if (encodingPanel != null)
+		if (encodingPanel != null) {
 			encoding = encodingPanel.getEncoding();
+		}
 		super.okPressed();
 	}
 

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/dialogs/ErrorSettingsPanel.java

@@ -21,7 +21,7 @@
  */
 public class ErrorSettingsPanel extends AbstractConfigurationPanel {
 
-	private String errorMessage;
+	private final String errorMessage;
 
 	/**
 	 * Constructor.