Improve error lggging around TerminalServiceRunnable

Prior to this change there were many exceptions that would simply
disappear inside the CompletableFuture since no error handling was
implemented. This commit adds basic error handling of logging failed
futures.

Author: jonahgraham

terminal/bundles/org.eclipse.terminal.connector.local/src/org/eclipse/terminal/connector/local/launcher/LocalLauncherHandler.java

@@ -19,6 +19,7 @@
 import org.eclipse.core.commands.AbstractHandler;
 import org.eclipse.core.commands.ExecutionEvent;
 import org.eclipse.core.commands.ExecutionException;
+import org.eclipse.core.runtime.ILog;
 import org.eclipse.core.runtime.IPath;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.IStructuredSelection;
@@ -72,11 +73,11 @@ private void executeDelegate(ISelection selection, ILauncherDelegate delegate) t
 		Map<String, Object> properties = new HashMap<>();
 		properties.put(ITerminalsConnectorConstants.PROP_DELEGATE_ID, delegate.getId());
 		properties.put(ITerminalsConnectorConstants.PROP_SELECTION, selection);
-		try {
-			delegate.execute(properties);
-		} catch (Exception e) {
-			throw new ExecutionException(e.getMessage(), e);
-		}
+		delegate.execute(properties).whenComplete((r, e) -> {
+			if (e != null) {
+				ILog.get().error("Error occurred while running delegate to open console", e); //$NON-NLS-1$
+			}
+		});
 	}
 
 }

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/TerminalService.java

@@ -20,7 +20,6 @@
 
 import org.eclipse.core.runtime.Assert;
 import org.eclipse.core.runtime.CoreException;
-import org.eclipse.core.runtime.ILog;
 import org.eclipse.core.runtime.ISafeRunnable;
 import org.eclipse.core.runtime.ListenerList;
 import org.eclipse.core.runtime.SafeRunner;
@@ -261,11 +260,7 @@ public void run(TerminalViewId tvid, String title, ITerminalConnector connector,
 				} else {
 					// First, restore the view. This opens consoles from the memento
 					fRestoringView = true;
-					try {
-						consoleViewManager.showConsoleView(tvid);
-					} catch (CoreException e) {
-						ILog.get().log(e.getStatus());
-					}
+					consoleViewManager.showConsoleView(tvid);
 					fRestoringView = false;
 					doRun(tvid, title, connector, data);
 				}
@@ -306,15 +301,12 @@ private void doRun(TerminalViewId tvid, String title, ITerminalConnector connect
 	@Override
 	public CompletableFuture<?> closeConsole(Map<String, Object> properties) {
 		Assert.isNotNull(properties);
-		return executeServiceOperation(properties,
-				(tvid, title, connector, data) -> consoleViewManager.closeConsole(tvid, title, connector, data));
+		return executeServiceOperation(properties, consoleViewManager::closeConsole);
 	}
 
 	@Override
 	public CompletableFuture<?> terminateConsole(Map<String, Object> properties) {
 		Assert.isNotNull(properties);
-
-		return executeServiceOperation(properties,
-				(tvid, title, connector, data) -> consoleViewManager.terminateConsole(tvid, title, connector, data));
+		return executeServiceOperation(properties, consoleViewManager::terminateConsole);
 	}
 }

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/handler/LaunchTerminalCommandHandler.java

@@ -23,6 +23,7 @@
 import org.eclipse.core.commands.ExecutionEvent;
 import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.CoreException;
+import org.eclipse.core.runtime.ILog;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.window.Window;
@@ -172,11 +173,11 @@ private void executeDelegate(ISelection selection, ILauncherDelegate delegate) t
 	}
 
 	private void executeDelegate(Map<String, Object> properties, ILauncherDelegate delegate) throws ExecutionException {
-		try {
-			delegate.execute(properties);
-		} catch (Exception e) {
-			throw new ExecutionException(e.getMessage(), e);
-		}
+		delegate.execute(properties).whenComplete((r, e) -> {
+			if (e != null) {
+				ILog.get().error("Error occurred while running delegate to open console", e); //$NON-NLS-1$
+			}
+		});
 	}
 
 }

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/local/showin/DynamicContributionItems.java

@@ -129,9 +129,14 @@ public void run() {
 				properties.put(ITerminalsConnectorConstants.PROP_TRANSLATE_BACKSLASHES_ON_PASTE,
 						Boolean.valueOf(translate));
 				try {
-					delegate.execute(properties);
+					delegate.execute(properties).whenComplete((r, e) -> {
+						if (e != null) {
+							ILog.get().error("Error occurred while running delegate to open console", e); //$NON-NLS-1$
+						}
+					});
 				} catch (Exception e) {
-					ILog.get().error(e.getMessage(), e);
+					// This wraps any synchronous exceptions - asynchronous exceptions are logged in the whenComplete above
+					ILog.get().error("Error occurred while running delegate to open console", e); //$NON-NLS-1$
 				}
 			}
 		};

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/view/TerminalsViewMementoHandler.java

@@ -201,9 +201,14 @@ private Optional<ILauncherDelegate> findDelegate(Map<String, Object> properties)
 
 	private void executeDelegate(Map<String, Object> properties, ILauncherDelegate delegate) {
 		try {
-			delegate.execute(properties);
+			delegate.execute(properties).whenComplete((r, e) -> {
+				if (e != null) {
+					ILog.get().error("Error occurred while running delegate to open console", e); //$NON-NLS-1$
+				}
+			});
 		} catch (Exception e) {
-			ILog.get().error(e.getMessage(), e);
+			// This wraps any synchronous exceptions - asynchronous exceptions are logged in the whenComplete above
+			ILog.get().error("Error occurred while running delegate to open console", e); //$NON-NLS-1$
 		}
 	}