Merge branch 'eclipse-platform:master' into issue-472-build_block_user_action

Author: haideryaqoob720

Jenkinsfile

@@ -29,12 +29,15 @@ pipeline {
 			post {
 				always {
 					archiveArtifacts artifacts: '.*log,**/target/**/.*log', allowEmptyArchive: true
-					junit '**/target/surefire-reports/TEST-*.xml'
+					junit allowEmptyResults: true, testResults: '**/target/surefire-reports/TEST-*.xml'
 					discoverGitReferenceBuild referenceJob: 'eclipse.platform/master'
-					recordIssues(publishAllIssues:false, ignoreQualityGate:true,
-						tool: eclipse(name: 'Compiler and API Tools', pattern: '**/target/compilelogs/*.xml'),
-						qualityGates: [[threshold: 1, type: 'DELTA', unstable: true]])
-					recordIssues publishAllIssues:false, tools: [mavenConsole(), javaDoc()]
+					recordIssues enabledForFailure: true, publishAllIssues:false, ignoreQualityGate:true,
+						tools: [
+							eclipse(name: 'Compiler', pattern: '**/target/compilelogs/*.xml'),
+							issues(name: 'API Tools', id: 'apitools', pattern: '**/target/apianalysis/*.xml')
+						],
+						qualityGates: [[threshold: 1, type: 'DELTA', unstable: true]]
+					recordIssues enabledForFailure: true, publishAllIssues:false, tools: [mavenConsole(), javaDoc()]
 				}
 			}
 		}

README.md

@@ -38,7 +38,7 @@ For additional documentation, please refer to the [docs directory](./docs) and [
 
 ## Issue Tracking
 
-This project uses Github to track ongoing development and issues. In case you have an issue, please read the information about Eclipse being a [community project](https://github.com/eclipse-platform#community) and bear in mind that this project is almost entirely developed by volunteers. So the contributors may not be able to look into every reported issue. You will also find the information about [how to find and report issues](https://github.com/eclipse-platform#reporting-issues) in repositories of the `eclipse-platform` organization there. Be sure to search for existing issues before you create another one.
+This project uses GitHub to track ongoing development and issues. In case you have an issue, please read the information about Eclipse being a [community project](https://github.com/eclipse-platform#community) and bear in mind that this project is almost entirely developed by volunteers. So the contributors may not be able to look into every reported issue. You will also find the information about [how to find and report issues](https://github.com/eclipse-platform#reporting-issues) in repositories of the `eclipse-platform` organization there. Be sure to search for existing issues before you create another one.
 
 In case you want to report an issue that is specific to this `eclipse.platform` repository, you can [find existing issues](https://github.com/eclipse-platform/eclipse.platform/issues) or [create new issues](https://github.com/eclipse-platform/eclipse.platform/issues/new) within this repository.
 

debug/org.eclipse.debug.core/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.debug.core; singleton:=true
-Bundle-Version: 3.22.100.qualifier
+Bundle-Version: 3.23.0.qualifier
 Bundle-Activator: org.eclipse.debug.core.DebugPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/DebugPlugin.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2021 IBM Corporation and others.
+ * Copyright (c) 2000, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -22,9 +22,12 @@
 import java.nio.charset.StandardCharsets;
 import java.text.MessageFormat;
 import java.util.ArrayList;
+import java.util.Comparator;
 import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 
 import javax.xml.parsers.DocumentBuilder;
 import javax.xml.parsers.FactoryConfigurationError;
@@ -170,6 +173,14 @@ public class DebugPlugin extends Plugin {
 	 */
 	public static final String EXTENSION_POINT_PROCESS_FACTORIES = "processFactories"; //$NON-NLS-1$
 
+	/**
+	 * Simple identifier constant (value <code>"execFactories"</code>) for the
+	 * exec factories extension point.
+	 *
+	 * @since 3.23
+	 */
+	public static final String EXTENSION_POINT_EXEC_FACTORIES = "execFactories"; //$NON-NLS-1$
+
 	/**
 	 * Simple identifier constant (value <code>"logicalStructureTypes"</code>) for the
 	 * logical structure types extension point.
@@ -368,6 +379,13 @@ public class DebugPlugin extends Plugin {
 	 */
 	public static final String ATTR_PATH = PI_DEBUG_CORE + ".ATTR_PATH"; //$NON-NLS-1$
 
+	/**
+	 * Attribute key for breakpoint grouping types accelerators
+	 *
+	 * @since 3.23
+	 */
+	public static final String PREF_SHOW_BREAKPOINT_GROUPBY_TYPE_SHORTCUTS = PI_DEBUG_CORE + ".PREF_FOR_BP_GROUP_TYPE_ACCELERATOR"; //$NON-NLS-1$
+
 	/**
 	 * Launch configuration attribute that designates whether or not the
 	 * descendants of the {@link IProcess} associated to a launch of this
@@ -438,6 +456,11 @@ public class DebugPlugin extends Plugin {
 	 */
 	private HashMap<String, IConfigurationElement> fProcessFactories = null;
 
+	/**
+	 * List of exec factories.
+	 */
+	private List<ExecFactoryFacade> execFactories;
+
 	/**
 	 * Service tracker for the workspace service
 	 */
@@ -981,7 +1004,24 @@ public static Process exec(String[] cmdLine, File workingDirectory, String[] env
 	 * @since 3.14
 	 */
 	public static Process exec(String[] cmdLine, File workingDirectory, String[] envp, boolean mergeOutput) throws CoreException {
-		Process p = null;
+		List<ExecFactoryFacade> factories = DebugPlugin.getDefault().getExecFactories();
+		Optional<File> directory = shortenWindowsPath(workingDirectory);
+		Optional<Map<String, String>> envMap = Optional.ofNullable(envp).map(array -> {
+			Map<String, String> map = new LinkedHashMap<>();
+			for (String e : array) {
+				int index = e.indexOf('=');
+				if (index != -1) {
+					map.put(e.substring(0, index), e.substring(index + 1));
+				}
+			}
+			return Map.copyOf(map);
+		});
+		for (ExecFactoryFacade holder : factories) {
+			Optional<Process> exec = holder.exec(cmdLine.clone(), directory, envMap, mergeOutput);
+			if (exec.isPresent()) {
+				return exec.get();
+			}
+		}
 		try {
 			// starting with and without merged output could be done with the
 			// same process builder approach but since the handling of
@@ -990,25 +1030,18 @@ public static Process exec(String[] cmdLine, File workingDirectory, String[] env
 			// builder to not break existing caller of this method
 			if (mergeOutput) {
 				ProcessBuilder pb = new ProcessBuilder(cmdLine);
-				if (workingDirectory != null) {
-					pb.directory(shortenWindowsPath(workingDirectory));
-				}
+				directory.ifPresent(pb::directory);
 				pb.redirectErrorStream(mergeOutput);
-				if (envp != null) {
+				if (envMap.isPresent()) {
 					Map<String, String> env = pb.environment();
 					env.clear();
-					for (String e : envp) {
-						int index = e.indexOf('=');
-						if (index != -1) {
-							env.put(e.substring(0, index), e.substring(index + 1));
-						}
-					}
+					env.putAll(envMap.get());
 				}
-				p = pb.start();
-			} else if (workingDirectory == null) {
-				p = Runtime.getRuntime().exec(cmdLine, envp);
+				return pb.start();
+			} else if (directory.isEmpty()) {
+				return Runtime.getRuntime().exec(cmdLine, envp);
 			} else {
-				p = Runtime.getRuntime().exec(cmdLine, envp, shortenWindowsPath(workingDirectory));
+				return Runtime.getRuntime().exec(cmdLine, envp, directory.get());
 			}
 		} catch (IOException e) {
 			Status status = new Status(IStatus.ERROR, getUniqueIdentifier(), ERROR, DebugCoreMessages.DebugPlugin_0, e);
@@ -1021,18 +1054,18 @@ public static Process exec(String[] cmdLine, File workingDirectory, String[] env
 			if (handler != null) {
 				Object result = handler.handleStatus(status, null);
 				if (result instanceof Boolean resultValue && resultValue) {
-					p = exec(cmdLine, null);
+					return exec(cmdLine, null);
 				}
 			}
 		}
-		return p;
+		return null;
 	}
 
 	// https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
 	private static final int WINDOWS_MAX_PATH = 258;
 
-	private static File shortenWindowsPath(File path) {
-		if (path.getPath().length() > WINDOWS_MAX_PATH && Platform.OS.isWindows()) {
+	private static Optional<File> shortenWindowsPath(File path) {
+		if (path != null && path.getPath().length() > WINDOWS_MAX_PATH && Platform.OS.isWindows()) {
 			// When spawning new processes on Windows, there is no uniform way
 			// to use long working directory paths that exceed the default path
 			// length limit, like for example using the raw path prefix '\\?\'
@@ -1042,12 +1075,12 @@ private static File shortenWindowsPath(File path) {
 			@SuppressWarnings("restriction")
 			String shortPath = org.eclipse.core.internal.filesystem.local.Win32Handler.getShortPathName(path.toString());
 			if (shortPath != null) {
-				return new File(shortPath);
+				return Optional.of(new File(shortPath));
 			} else {
 				log(Status.warning("Working directory of process to create exceeds Window's MAX_PATH limit and shortening the path failed.")); //$NON-NLS-1$
 			}
 		}
-		return path;
+		return Optional.ofNullable(path);
 	}
 
 	/**
@@ -1189,6 +1222,39 @@ private void initializeProcessFactories() {
 		}
 	}
 
+	private synchronized List<ExecFactoryFacade> getExecFactories() {
+		if (execFactories == null) {
+			IExtensionPoint extensionPoint = Platform.getExtensionRegistry().getExtensionPoint(DebugPlugin.PI_DEBUG_CORE, EXTENSION_POINT_EXEC_FACTORIES);
+			IConfigurationElement[] infos = extensionPoint.getConfigurationElements();
+			List<ExecFactoryFacade> list = new ArrayList<>();
+			for (IConfigurationElement configurationElement : infos) {
+				String clz = configurationElement.getAttribute("class"); //$NON-NLS-1$
+				if (clz != null) {
+					int priority;
+					String attribute = configurationElement.getAttribute("priority"); //$NON-NLS-1$
+					if (attribute == null) {
+						priority = 0;
+					}
+					try {
+						priority = Integer.parseInt(attribute);
+					} catch (NumberFormatException e) {
+						log(new Status(IStatus.ERROR, DebugPlugin.PI_DEBUG_CORE, ERROR, MessageFormat.format(DebugCoreMessages.DebugPlugin_invalid_exec_factory, new Object[] {
+								configurationElement.getContributor().getName() }), null));
+						priority = 0;
+					}
+					list.add(new ExecFactoryFacade(configurationElement, priority));
+				} else {
+					String badDefiner = configurationElement.getContributor().getName();
+					log(new Status(IStatus.ERROR, DebugPlugin.PI_DEBUG_CORE, ERROR, MessageFormat.format(DebugCoreMessages.DebugPlugin_invalid_exec_factory, new Object[] {
+							badDefiner }), null));
+				}
+			}
+			list.sort(Comparator.comparingInt(ExecFactoryFacade::getPriority).reversed());
+			execFactories = List.copyOf(list);
+		}
+		return execFactories;
+	}
+
 	private void invalidStatusHandler(Exception e, String id) {
 		log(new Status(IStatus.ERROR, DebugPlugin.PI_DEBUG_CORE, ERROR, MessageFormat.format(DebugCoreMessages.DebugPlugin_5, new Object[] { id }), e));
 	}
@@ -1213,14 +1279,41 @@ public int hashCode() {
 
 		@Override
 		public boolean equals(Object obj) {
-			if (obj instanceof StatusHandlerKey) {
-				StatusHandlerKey s = (StatusHandlerKey)obj;
+			if (obj instanceof StatusHandlerKey s) {
 				return fCode == s.fCode && fPluginId.equals(s.fPluginId);
 			}
 			return false;
 		}
 	}
 
+	private class ExecFactoryFacade implements ExecFactory {
+
+		private IConfigurationElement element;
+		private int priority;
+
+		ExecFactoryFacade(IConfigurationElement element, int priority) {
+			this.element = element;
+			this.priority = priority;
+		}
+
+		public int getPriority() {
+			return priority;
+		}
+
+		@Override
+		public Optional<Process> exec(String[] cmdLine, Optional<File> workingDirectory, Optional<Map<String, String>> environment, boolean mergeOutput) throws CoreException {
+			ExecFactory extension;
+			try {
+				extension = (ExecFactory) element.createExecutableExtension(IConfigurationElementConstants.CLASS);
+			} catch (CoreException e) {
+				log(e);
+				return Optional.empty();
+			}
+			return extension.exec(cmdLine, workingDirectory, environment, mergeOutput);
+		}
+
+	}
+
 	/**
 	 * Executes runnables after event dispatch is complete.
 	 *

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/ExecFactory.java

@@ -0,0 +1,50 @@
+/*******************************************************************************
+ * Copyright (c) 2025 Christoph Läubrich and others.
+ *
+ * This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License 2.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-2.0/
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *
+ * Contributors:
+ *     Christoph Läubrich - initial API and implementation
+ *******************************************************************************/
+package org.eclipse.debug.core;
+
+import java.io.File;
+import java.util.Map;
+import java.util.Optional;
+
+import org.eclipse.core.runtime.CoreException;
+
+/**
+ * A {@link ExecFactory} can be used to control how Eclipse forks a new
+ * {@link Process}.
+ *
+ * @since 3.23
+ */
+public interface ExecFactory {
+
+	/**
+	 * Executes the given command with the provided working directory and
+	 * environment
+	 *
+	 * @param cmdLine the commandline to execute
+	 * @param workingDirectory an optional working directory to be used
+	 *            otherwise the process factory must use its default
+	 * @param environment the environment to use, if empty the process factory
+	 *            must use its defaults
+	 * @param mergeOutput <code>true</code> if standard error and standard out
+	 *            should be merged
+	 * @return an {@link Optional} describing the new process created, if an
+	 *         empty {@link Optional} is returned it is assumed that this
+	 *         factory is not capable of executing the provided command with the
+	 *         requested settings
+	 * @throws CoreException if the factory is capable of execution but the
+	 *             creation of a process itself has failed
+	 */
+	Optional<Process> exec(String[] cmdLine, Optional<File> workingDirectory, Optional<Map<String, String>> environment, boolean mergeOutput) throws CoreException;
+
+}

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/Launch.java

@@ -527,10 +527,9 @@ public void disconnect() throws DebugException {
 		readLock.lock();
 		try {
 			for (IProcess process : getProcesses0()) {
-				if (process instanceof IDisconnect) {
-					IDisconnect dis = (IDisconnect) process;
-					if (dis.canDisconnect()) {
-						dis.disconnect();
+				if (process instanceof IDisconnect disc) {
+					if (disc.canDisconnect()) {
+						disc.disconnect();
 					}
 				}
 			}

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/commands/AbstractDebugCommand.java

@@ -187,8 +187,7 @@ public boolean contains(ISchedulingRule rule) {
 
 		@Override
 		public boolean isConflicting(ISchedulingRule rule) {
-			if (rule instanceof SerialPerObjectRule) {
-				SerialPerObjectRule vup = (SerialPerObjectRule) rule;
+			if (rule instanceof SerialPerObjectRule vup) {
 				return fObject == vup.fObject;
 			}
 			return false;

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/model/RuntimeProcess.java

@@ -166,6 +166,22 @@ public RuntimeProcess(ILaunch launch, Process process, String name, Map<String,
 		launch.addProcess(this);
 		fMonitor.start();
 		fireCreationEvent();
+		startStreams();
+	}
+
+	/**
+	 * Called after notification that this runtime process is created to start
+	 * the reading of streams. Must be overridden if a custom
+	 * {@link IStreamsProxy} instance is provided by
+	 * {@link #createStreamsProxy()} that do not extends {@link StreamsProxy}
+	 * and does not start the stream reading in any other mean.
+	 *
+	 * @since 3.23
+	 */
+	protected void startStreams() {
+		if (fStreamsProxy instanceof StreamsProxy impl) {
+			impl.startMonitoring(fThreadNameSuffix);
+		}
 	}
 
 	private static String getPidInfo(Process process, ILaunch launch) {
@@ -389,7 +405,7 @@ protected IStreamsProxy createStreamsProxy() {
 		if (charset == null) {
 			charset = Platform.getSystemCharset();
 		}
-		return new StreamsProxy(getSystemProcess(), charset, fThreadNameSuffix);
+		return new StreamsProxy(getSystemProcess(), charset);
 	}
 
 	/**