Proxy messages written to log that cannot be satisfied

[rubenporras]

Similar to what is described in #258 I have the messages

!MESSAGE System property https.proxyHost is not set but should be ...
!MESSAGE System property https.proxyPort is not set but should be ...
!MESSAGE System property https.proxyHost is not set but should be ...
!MESSAGE System property https.proxyPort is not set but should be ...

I understand that this is advisable to do, as otherwise there is a window between the start of the java application and the time that the org.eclipse.core.net is activated, where the system properties are not set to the desired value.

I have set the system property in my .ini file to match the settings set for the org.eclipse.core.net plug-in, but then I get the messages

"System property {0} has been set to {1} by an external source. This value will be overwritten using the values from the preferences"

which is quite confusing because it does not realize that the external source and the one from the preferences define the same values. Since it looks like ProxyType already checks for the properties being equal, I suggest we remove the check that outputs the later message.

[fedejeanne]

Thank you for reporting this issue and suggesting the enahancement, @rubenporras !

Are you planning on providing a PR for this?

[rubenporras]

Hi @fedejeanne , I did the PR in #1952

[fedejeanne]

Thank you, I missed that. Can you please adapt the commit message in your PR so it references this issue as described in the recommendations (you need to add 2 references to this issue)?

Also, a simple way to reproduce this behavior (just the steps) and also your current preferences (you may of course anonymize the actual IPs) would help understanding the issue more in detail. I have to confess that I am not experienced in this particular area but it seems to me that your PR disables the verification for all OSes which may also introduce a security issue. You mentioned that the check for equal is done later but it is difficult to validate this without knowing the exact steps you used to reproduce this behavior.

Just for informational purpose, I am linking the original approach that you took, which was originally added to fix an issue for Mac:

• Issue: https://bugs.eclipse.org/bugs/show_bug.cgi?id=564923
• Fix: 7f7dbae

[rubenporras]

Thanks for the comment. I have adapted the commit message.

To reproduce the problem, you need to add

org.eclipse.core.net/proxiesEnabled=true
org.eclipse.core.net/proxyData/HTTP/host=xxx
org.eclipse.core.net/proxyData/HTTP/port=nnn
org.eclipse.core.net/proxyData/HTTPS/host=xxx
org.eclipse.core.net/proxyData/HTTPS/port=nnn
org.eclipse.core.net/proxyData/HTTPS/hasAuth=true
org.eclipse.core.net/nonProxiedHosts=zzz

Then, you will get the messages of the type "System property {0} is not set but should be ..."

If then you add

-Dhttp.proxyHost=xxx
-Dhttp.proxyPort=nnn
-Dhttps.proxyHost=xxx
-Dhttps.proxyPort=nnn
...

then you get the message of the type "System property {0} has been set to {1} by an external source. This value will be overwritten using the values from the preferences".

I think we can apply the PR I suggest because verification will happen always in verifySystemPropertyEquals, called as part of setProxyData . This is the place where "System property {0} is not set but should be ..." is currently output. This also has the advantage of not having OS specific code.

Regards