-
Notifications
You must be signed in to change notification settings - Fork 146
Prepare 4.38 development #2134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 4.38 development #2134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automated changes look good, but it seems like org.eclipse.help.webapp get different byte-code generated although it hasn't been touched:
[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:5.0.0-SNAPSHOT:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.help.webapp: Baseline and reactor have the same fully qualified version, but different content
[ERROR] different
[ERROR] META-INF/ECLIPSE_.RSA: present in baseline only
[ERROR] META-INF/ECLIPSE_.SF: present in baseline only
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/advanced_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/bookmarksToolbar_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/bookmarksView_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/confirmShowAll_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/contentToolbar_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/content_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/deferredView_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/helpToolbar_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/help_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/indexToolbar_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/indexView_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/index_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/nav_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/printConfirm_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/printError_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/print_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/quickSearch_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/searchScoped_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/searchSimple_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/searchToolbar_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/searchView_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/tabs_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/tocToolbar_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/tocView_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/toolbar_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/view_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/views_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/workingSetManager_jsp.class: different
[ERROR] org/eclipse/help/internal/webapp/jsp/advanced/workingSet_jsp.class: different
[ERROR] -> [Help 1]
This should be investigated and if this is requires e.g. a touch on each release, it should be automated with a corresponding individual preparation script like already used in SWT and Equinox.
Looks like as Unfortunately I haven't recorded much context. |
|
I remember doing it many times but not why. |
OK, then let's just enforce a new qualifier for now and investigate and automate/avoid it later. |
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
I ran the build locally with the |
b1b4d73 to
6bea803
Compare
Prepare development of Eclipse 4.38.
This complements: