Skip to content

Clean Code for debug/org.eclipse.ui.console #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Clean Code for debug/org.eclipse.ui.console #2268

wants to merge 2 commits into from
+1 −2

Conversation

@eclipse-platform-bot
Copy link
Contributor

@eclipse-platform-bot eclipse-platform-bot commented Nov 12, 2025

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Contributor Author

eclipse-platform-bot commented Nov 12, 2025 •
edited
Loading

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.ui.console/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 9bad4d17d085f216df8388dbbb13064f3872c3b1 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 13 Nov 2025 03:11:53 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/debug/org.eclipse.ui.console/META-INF/MANIFEST.MF b/debug/org.eclipse.ui.console/META-INF/MANIFEST.MF
index 77a7668e48..8443393691 100644
--- a/debug/org.eclipse.ui.console/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.ui.console/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.console; singleton:=true
-Bundle-Version: 3.14.400.qualifier
+Bundle-Version: 3.14.500.qualifier
 Bundle-Activator: org.eclipse.ui.console.ConsolePlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025 •
edited
Loading

Test Results

 1 926 files   -  27   1 926 suites   - 27   1h 57m 47s ⏱️ + 34m 26s
 4 744 tests ±  0   4 712 ✅  -   8   24 💤 ±0  8 ❌ +8 
14 079 runs   - 153  13 889 ✅  - 161  182 💤 ±0  8 ❌ +8 

For more details on these failures, see this check.

Results for commit e90dacd. ± Comparison against base commit 24be9b0.

♻️ This comment has been updated with latest results.

@deepika-u
Copy link
Contributor

deepika-u commented Nov 12, 2025

For warning caused from getVisibleLinesInViewport(), revert is created in ->eclipse-platform/eclipse.platform.ui#3538

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/debug/org.eclipse.ui.console branch from 5f24b27 to 415a033 Compare November 13, 2025 03:05
@laeubi laeubi closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eclipse-platform-bot @deepika-u @laeubi