Skip to content

Commit 931da83

Browse files
committed
Reformat to one sentence per line
Fixes #57. Also contains many other cleanups of wrong formatting.
1 parent 2b2cf95 commit 931da83

10 files changed

+2216
-3003
lines changed

best_practices.adoc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ In this section, we provide examples of best practices for designing and impleme
77

88
When designing editors that provide syntax or compilation checking support, follow the Java tooling design in the Eclipse platform.
99

10-
Provide on the fly syntax checking if possible. Use red "squiggle" to indicate where the potential error is located in the source code.
10+
Provide on the fly syntax checking if possible.
11+
Use red "squiggle" to indicate where the potential error is located in the source code.
1112
Use a red box on the side bar on the right side to indicate the approximate error position in the file.
1213
Use a prominent marker on the upper right hand corner to indicate that the file contains errors or warnings.
1314
Use red color to indicate errors, and use yellow to indicate warnings.
@@ -64,7 +65,8 @@ The objective is to reduce the number of context menu items to *no more than 20*
6465

6566
For Flat Look design, when using buttons with ellipses (except for the btn:[More...] button), it should pop up a secondary window which can be a dialog box or a wizard.
6667

67-
Use Title capitalization for section titles. The distance between section columns should be 32 pixels.
68+
Use Title capitalization for section titles.
69+
The distance between section columns should be 32 pixels.
6870

6971
On pages with listbox on the left hand side, the distance be between the list box and the right-hand column (e.g., showing properties for a selected listbox item) should be 10 pixels.
7072

component_dev.adoc

Lines changed: 732 additions & 1038 deletions
Large diffs are not rendered by default.

eclipse_ui_full_checklist.adoc

Lines changed: 167 additions & 244 deletions
Large diffs are not rendered by default.

flat_look_design.adoc

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ image::images/Flatlook1.gif[flatlook1]
99
The Flat Look design may be more suitable for certain type of user tasks, and more appealing to certain user profile.
1010
However, this design should not be used just because it provides a different look than the native platform look and feel.
1111
The use of Flat Look design should be considered in the context of the supported user scenarios.
12-
This design is usually a good fit for extensive property and configuration editing, such as editing Eclipse's `plugin.xml` file, and J2EE Web application's deployment descriptors.
12+
This design is usually a good fit for extensive property and configuration editing,
13+
such as editing Eclipse's `plugin.xml` file, and J2EE Web application's deployment descriptors.
1314

1415
TIP: [[guideline16.1]]*Guideline 16.1* +
1516
Use Flat Look design for user scenarios that involve extensive property and configuration editing.
@@ -23,11 +24,13 @@ image::images/Flatlook3.gif[flatlook3]
2324
TIP: [[guideline16.2]]*Guideline 16.2* +
2425
Have the core sections on the overview page expanded.
2526

26-
Don't use tabs within a Flat Look editor tab. Use an alternative design or rendering of the tabs.
27+
Don't use tabs within a Flat Look editor tab.
28+
Use an alternative design or rendering of the tabs.
2729

2830
image::images/Flatlook4.gif[flatlook4]
2931

30-
When applicable, always provide a "Source" tab. Assign mnemonics for sections, controls, etc. for keyboard navigation.
32+
When applicable, always provide a "Source" tab.
33+
Assign mnemonics for sections, controls, etc. for keyboard navigation.
3134

3235
image::images/Flatlook5.gif[flatlook5]
3336

general_ui_guidelines.adoc

Lines changed: 64 additions & 89 deletions
Original file line numberDiff line numberDiff line change
@@ -2,152 +2,127 @@
22
== General UI Guidelines
33

44

5-
This document defines UI guidelines that are unique and specific to the
6-
Eclipse platform. It is a supplement to the other standard UI guidelines
7-
such as
5+
This document defines UI guidelines that are unique and specific to the Eclipse platform.
6+
It is a supplement to the other standard UI guidelines such as
87

98
- https://learn.microsoft.com/en-us/windows/apps/design/[Microsoft® Windows Design Guidelines]
109
- https://developer.apple.com/design/human-interface-guidelines/guidelines/overview/[Apple® Human Interface Guidelines]
1110
- https://developer.gnome.org/hig/[GNOME Human Interface Guidelines]
1211
- https://www.oracle.com/java/technologies/java-look-and-feel-graphics-repository.html[Java Look and Feel Guidelines]
1312

14-
You should continue to consult those guidelines for basic UI design and
15-
implementation recommendations.
13+
You should continue to consult those guidelines for basic UI design and implementation recommendations.
1614

17-
It is expected that you already have a basic understanding of the
18-
Eclipse UI architecture and APIs, and the basic UI design principles:
19-
user in control, directness, consistency, forgiveness, feedback,
20-
aesthetics, and simplicity. If you do not currently have the
21-
prerequisite knowledge, please read the relevant documentation first.
15+
It is expected that you already have a basic understanding of the Eclipse UI architecture and APIs,
16+
and the basic UI design principles:
17+
user in control, directness, consistency, forgiveness, feedback, aesthetics, and simplicity.
18+
If you do not currently have the prerequisite knowledge, please read the relevant documentation first.
2219

2320
TIP: [[guideline1.1]]*Guideline 1.1* +
24-
Follow and apply good user interface design principles: user in control,
25-
directness, consistency, forgiveness, feedback, aesthetics, and
26-
simplicity.
21+
Follow and apply good user interface design principles:
22+
user in control, directness, consistency, forgiveness, feedback, aesthetics, and simplicity.
2723

2824

2925
=== The Spirit of Eclipse
3026

31-
At its heart, Eclipse is a platform for tool plug-ins. These plug-ins
32-
may be developed by a single team or by a partnership of teams, or the
33-
user may assemble a set of plug-ins from diverse sources. In either
34-
case, the usability of an individual tool, and Eclipse as a whole, will
35-
be positively influenced by user interface consistency.
27+
At its heart, Eclipse is a platform for tool plug-ins.
28+
These plug-ins may be developed by a single team or by a partnership of teams,
29+
or the user may assemble a set of plug-ins from diverse sources.
30+
In either case, the usability of an individual tool, and Eclipse as a whole,
31+
will be positively influenced by user interface consistency.
3632

37-
If you're in doubt about the appropriate look and feel for a tool, look
38-
to the platform first, then the Java development tooling and the Plug-in
39-
Development Environment (PDE) in Eclipse for guidance. In many cases,
40-
the workflow you imagine may already exist in Eclipse. If so, adopt the
41-
platform's workflow and user interface conventions. This will lead to
42-
greater consistency with the platform and other plug-ins, and an easier
43-
learning curve for your customers.
33+
If you're in doubt about the appropriate look and feel for a tool, look to the platform first,
34+
then the Java development tooling and the Plug-in Development Environment (PDE) in Eclipse for guidance.
35+
In many cases, the workflow you imagine may already exist in Eclipse.
36+
If so, adopt the platform's workflow and user interface conventions.
37+
This will lead to greater consistency with the platform and other plug-ins,
38+
and an easier learning curve for your customers.
4439

45-
In some scenarios, it may be tempting to ignore the workflow of Eclipse
46-
and implement a "custom" user interface. This interface will almost
47-
certainly stand out like a sore thumb in an integrated environment,
48-
where other tools adopt the platform conventions. You lose the benefit
49-
of past experience, and force your customers to learn new ideas.
40+
In some scenarios, it may be tempting to ignore the workflow of Eclipse and implement a "custom" user interface.
41+
This interface will almost certainly stand out like a sore thumb in an integrated environment,
42+
where other tools adopt the platform conventions.
43+
You lose the benefit of past experience, and force your customers to learn new ideas.
5044

51-
Consult the xref:best_practices.adoc[Best Practices] section for examples
52-
and more information.
45+
Consult the xref:best_practices.adoc[Best Practices] section for examples and more information.
5346

54-
Also, visit the https://github.com/eclipse-platform[Eclipse
55-
Platform @ GitHub] to share information with the community.
47+
Also, visit the https://github.com/eclipse-platform[Eclipse Platform @ GitHub] to share information with the community.
5648

5749
TIP: [[guideline1.2]]*Guideline 1.2* +
5850
Follow the platform lead for user interface conventions.
5951

60-
If you decide to reuse the conventions of Eclipse, be careful not to
61-
misappropriate Eclipse specific UI conventions. For instance, the active
62-
part in a workbench window is indicated by a shaded title. The use of
63-
shaded titles within an editor (see below) may be one way to indicate
64-
where the focus is, within that part, but it will also blur the concept
65-
of part activation in the window.
52+
If you decide to reuse the conventions of Eclipse, be careful not to misappropriate Eclipse specific UI conventions.
53+
For instance, the active part in a workbench window is indicated by a shaded title.
54+
The use of shaded titles within an editor (see below) may be one way to indicate where the focus is,
55+
within that part, but it will also blur the concept of part activation in the window.
6656

6757
image::images/badHilight.png[badHilight]
6858

6959
TIP: [[guideline1.34]]*Guideline 1.3* +
70-
Be careful not to mix UI metaphors. It may blur the original concept,
71-
and your own application.
60+
Be careful not to mix UI metaphors.
61+
It may blur the original concept, and your own application.
7262

7363
TIP: [[guideline1.4]]*Guideline 1.4* +
7464
If you have an interesting idea, work with the Eclipse community to make Eclipse a better platform for all.
7565

7666
=== Capitalization
7767

78-
Consistent capitalization of text within a plug-in leads to a more
79-
polished feel, and greater perception of quality. Within a dialog or
80-
window, headline capitalization should be applied to all titles, menus,
81-
tooltip, tabs, and push buttons. For example, "Run to Line" can be used
82-
as a menu item label.
68+
Consistent capitalization of text within a plug-in leads to a more polished feel,
69+
and greater perception of quality.
70+
Within a dialog or window, headline capitalization should be applied to all titles, menus, tooltip, tabs, and push buttons.
71+
For example, "Run to Line" can be used as a menu item label.
8372

84-
Sentence style capitalization should be applied to all check boxes,
85-
radio buttons, and group labels. For example, "Choose an option for the
86-
Java file" can be used as a group label.
73+
Sentence style capitalization should be applied to all check boxes,radio buttons, and group labels.
74+
For example, "Choose an option for the Java file" can be used as a group label.
8775

8876
TIP: [[guideline1.5]]*Guideline 1.5* +
89-
Use Headline style capitalization for menus, tooltip and all titles,
90-
including those used for windows, dialogs, tabs, column headings and
91-
push buttons. Capitalize the first and last words, and all nouns,
92-
pronouns, adjectives, verbs and adverbs. Do not include ending
93-
punctuation.
77+
Use Headline style capitalization for menus, tooltip and all titles, including those used for windows, dialogs, tabs, column headings and push buttons.
78+
Capitalize the first and last words, and all nouns, pronouns, adjectives, verbs and adverbs.
79+
Do not include ending punctuation.
9480

9581
TIP: [[guideline1.6]]*Guideline 1.6* +
96-
Use Sentence style capitalization for all control labels in a dialog or
97-
window, including those for check boxes, radio buttons, group labels,
98-
and simple text fields. Capitalize the first letter of the first word,
99-
and any proper names such as the word Java.
82+
Use Sentence style capitalization for all control labels in a dialog or window, including those for check boxes, radio buttons, group labels, and simple text fields.
83+
Capitalize the first letter of the first word, and any proper names such as the word Java.
10084

10185
=== Language
102-
Eclipse is available on a variety of different platforms, in a variety
103-
of locales. In reflection of the different languages and numeric formats
104-
in each, a localization strategy should be adopted for the text and
105-
images within each plug-in. This involves the separation of all
106-
resources from the source code of a plug-in itself, so that those
107-
resources can be translated to a new locale.
86+
Eclipse is available on a variety of different platforms, in a variety of locales.
87+
In reflection of the different languages and numeric formats in each,
88+
a localization strategy should be adopted for the text and images within each plug-in.
89+
This involves the separation of all resources from the source code of a plug-in itself,
90+
so that those resources can be translated to a new locale.
10891

109-
Consult the xref:best_practices.adoc[Best Practices] section for examples
110-
and more information.
92+
Consult the xref:best_practices.adoc[Best Practices] section for examples and more information.
11193

11294
TIP: [[guideline1.7]]*Guideline 1.7* +
11395
Create localized version of the resources within your plug-in.
11496

11597
=== Error Handling
11698

117-
If an error occurs in Eclipse, the appropriate response will be
118-
dependent on the context of the error.
99+
If an error occurs in Eclipse, the appropriate response will be dependent on the context of the error.
119100

120-
Please refer to xref:component_dev.adoc#wizards[Wizards] section for
121-
guidelines on how to handle user input errors in a wizard.
101+
Please refer to xref:component_dev.adoc#wizards[Wizards] section for guidelines on how to handle user input errors in a wizard.
122102

123-
Please refer to xref:component_dev.adoc#editors[Editors] section for guidelines
124-
on how to handle errors occurring in an editor.
103+
Please refer to xref:component_dev.adoc#editors[Editors] section for guidelines on how to handle errors occurring in an editor.
125104

126-
When an error occurs which requires either an explicit user input or
127-
immediate attention from users, a modal dialog should be used to
128-
communicate the error to the user. This forces the user to notice, and
129-
deal with, the problem.
105+
When an error occurs which requires either an explicit user input or immediate attention from users,
106+
a modal dialog should be used to communicate the error to the user.
107+
This forces the user to notice, and deal with, the problem.
130108

131109
TIP: [[guideline1.8]]*Guideline 1.8* +
132-
When an error occurs which requires either an explicit user input or
133-
immediate attention from users, communicate the occurrence with a modal
134-
dialog.
110+
When an error occurs which requires either an explicit user input or immediate attention from users,
111+
communicate the occurrence with a modal dialog.
135112

136-
If a programming error occurs in the product, an error dialog should be
137-
used to communicate the occurrence to the user. The error should also be
138-
logged using the workbench error logging facility. This gives the user
139-
an opportunity to restart the platform, uninstall the corresponding
140-
feature, and contact their system administrator.
113+
If a programming error occurs in the product,
114+
an error dialog should be used to communicate the occurrence to the user.
115+
The error should also be logged using the workbench error logging facility.
116+
This gives the user an opportunity to restart the platform,
117+
uninstall the corresponding feature, and contact their system administrator.
141118

142-
The plug-in should provide the following information in the detail area
143-
of the error dialog:
119+
The plug-in should provide the following information in the detail area of the error dialog:
144120

145121
* Provider name
146122
* Plug-in name (user friendly name)
147123
* Plug-in ID
148124
* Version
149125

150126
TIP: [[guideline1.9]]*Guideline 1.9* +
151-
If a programming error occurs in the product, communicate the occurrence
152-
with a dialog, and log it.
127+
If a programming error occurs in the product, communicate the occurrence with a dialog, and log it.
153128

0 commit comments

Comments
 (0)