Skip to content

Commit cc24b28

Browse files
committed
[REMOVE]
1 parent 5b3b0ac commit cc24b28

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

.github/workflows/checkAcknowledgements.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,12 @@ jobs:
3838
}
3939
}
4040
}
41-
let hasMultipleNames = false
4241
for (const [profile, names] of contributorNames) {
4342
if (names.size > 1) {
4443
core.error("Multiple names found for profile '" + profile + "': " + Array.from(names).join(', '))
45-
hasMultipleNames = true
44+
core.setFailed('Multiple names for same contributor detected. See log for details.');
4645
}
4746
}
48-
if (hasMultipleNames) {
49-
core.setFailed('Multiple names for same contributor detected. See log for details.');
50-
}
5147
5248
function computeIfAbsent(map, key, valueSupplier) {
5349
let value = map.get(key)

.github/workflows/generateAcknowledgements.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,14 @@ jobs:
158158
const nameInconsistencies = []
159159
for (const [profile, names] of contributorNames) {
160160
// Select longest name, assuming that's correct
161-
let selectedName = names[0]
161+
let selectedName = names.values().next()
162162
const existingName = existingContributorNames.get(profile)
163163
if (existingName && (selectedName != existingName || names.size > 1)) {
164+
console.log('Name not equals:' + (selectedName != existingName))
165+
console.log('selectedName :' + selectedName)
166+
console.log('existingName :' + existingName)
167+
console.log('selectedName :' + (typeof selectedName))
168+
console.log('existingName :' + (typeof existingName))
164169
selectedName = existingName
165170
console.log("Reuse existing name '" + existingName + "' for " + profile + ", instead of encountered: " + Array.from(names).join(', '))
166171
} else if (names.size > 1) {

0 commit comments

Comments
 (0)