Added N&N for experimental HiDpi setting #242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
reviewed
Nov 4, 2024
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Would it make sense to also add a screenshot comparing existing and new scaling behavior at an example? That would make it easier to directly understand the benefits without reading the text and may increase interest in the feature in general.
In addition, please check the code formatting.
ShahzaibIbrahim
force-pushed
the
master
branch
from
1a7be62 to
b388d4c
Compare
Contributor
|
Sorry, I accidentially did a wrong push to the PR branch, which has closed the PR. Since I cannot push on that branch anymore, I pushed the branch to a different fork (including the existing author information accordingly) from which I created a new PR: #243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: vi-eclipse/Eclipse-Platform#134
PR: eclipse-platform/eclipse.platform.ui#2461