Add N&N for new image constructor #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedejeanne
reviewed
Feb 5, 2025
Member
There was a problem hiding this comment.
Looks good, just 2 minor comments after which, this PR is good to go. Thank you @HeikoKlare !
HeikoKlare
force-pushed
the
news-swt-1734
branch
from
255fb4b to
f238372
Compare
This contributes an N&N for the new image constructor for programmatically created, dynamically scaling images as required for enhanced UI scaling mechanisms, as contributed via eclipse-platform/eclipse.platform.swt#1734
HeikoKlare
force-pushed
the
news-swt-1734
branch
from
f238372 to
f1b8ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes an N&N for the new image constructor for programmatically created, dynamically scaling images as required for enhanced UI scaling mechanisms, as contributed via eclipse-platform/eclipse.platform.swt#1734