Merge pull request #187 from Chulhee1Lee/main

Unknown Node Handling Issue Fix ( not launch workload at worker node )

Author: youngtaekiim

.github/workflows/run-ci.yml

@@ -13,18 +13,15 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v4
 
-      # Step 2: Install Rust toolchain
-      - name: Install Rust toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-          override: true
-
-      # Step 3: Install Docker Compose dependencies (if needed)
-      - name: Install Docker Compose and utilities
+      # Step 2: Install essential dependencies including protobuf-compiler and dbus
+      - name: Install essential dependencies
         run: |
           sudo apt-get update -y
-          sudo apt-get install -y docker-compose jq curl lsb-release
+          sudo apt-get install -y docker-compose jq curl lsb-release protobuf-compiler libdbus-1-dev pkg-config build-essential
+
+      # Step 3: Install Rust toolchain
+      - name: Install Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
 
       # Step 4: Make all scripts executable
       - name: Make scripts executable

src/player/actioncontroller/src/manager.rs

@@ -134,7 +134,9 @@ impl ActionControllerManager {
                 println!("Node {} is nodeagent", model_node);
                 "nodeagent"
             } else {
-                continue; // Skip unknown node types
+                // Log warning for unknown node types and skip processing
+                println!("Warning: Node '{}' is not explicitly configured. Skipping deployment.", model_node);
+                continue;
             };
             println!(
                 "Processing model '{}' on node '{}' with action '{}'",
@@ -250,7 +252,9 @@ impl ActionControllerManager {
             } else if self.nodeagent_nodes.contains(&model_node) {
                 "nodeagent"
             } else {
-                continue; // Skip if node type is unknown
+                // Log warning for unknown node types and skip processing
+                println!("Warning: Node '{}' is not explicitly configured. Skipping deployment.", model_node);
+                continue;
             };
 
             if desired == Status::Running {
@@ -615,4 +619,21 @@ spec:
         assert!(manager.restart_workload("test".into()).await.is_ok());
         assert!(manager.pause_workload("test".into()).await.is_ok());
     }
+
+    #[test]
+    fn test_unknown_nodes_skipped() {
+        // Test that when creating a manager, unknown nodes are properly categorized
+        let manager = ActionControllerManager {
+            bluechi_nodes: vec!["HPC".to_string()],
+            nodeagent_nodes: vec!["ZONE".to_string()],
+        };
+
+        // Test that nodes are properly categorized
+        assert!(manager.bluechi_nodes.contains(&"HPC".to_string()));
+        assert!(manager.nodeagent_nodes.contains(&"ZONE".to_string()));
+        assert!(!manager.bluechi_nodes.contains(&"cloud".to_string()));
+        
+        // The logic now skips unknown nodes instead of processing them
+        // This test validates that the manager is set up correctly
+    }
 }