Merge pull request #405 from akshaylg0314/demo25

Fixing the CI/CD pipeline for uploading artifacts on github

Author: youngtaekiim

.github/workflows/run-ci.yml

@@ -289,26 +289,26 @@ jobs:
       #     name: code-coverage-html-agent
       #     path: dist/coverage/agent/tarpaulin-report-agent.html
 
-      # - name: Upload coverage report for player (lcov)
-      #   if: always()
-      #   uses: actions/upload-artifact@v4
-      #   with:
-      #     name: code-coverage-lcov-player
-      #     path: dist/coverage/player/lcov.info
+      - name: Upload coverage report for player (lcov)
+        if: always() && hashFiles('dist/coverage/player/lcov.info') != ''
+        uses: actions/upload-artifact@v4
+        with:
+          name: code-coverage-lcov-player
+          path: dist/coverage/player/lcov.info
 
-      # - name: Upload coverage report for player (xml)
-      #   if: always()
-      #   uses: actions/upload-artifact@v4
-      #   with:
-      #     name: code-coverage-xml-player
-      #     path: dist/coverage/player/cobertura.xml
+      - name: Upload coverage report for player (xml)
+        if: always() && hashFiles('dist/coverage/player/cobertura.xml') != ''
+        uses: actions/upload-artifact@v4
+        with:
+          name: code-coverage-xml-player
+          path: dist/coverage/player/cobertura.xml
 
-      # - name: Upload coverage report for player (html)
-      #   if: always()
-      #   uses: actions/upload-artifact@v4
-      #   with:
-      #     name: code-coverage-html-player
-      #     path: dist/coverage/player/tarpaulin-report-player.html
+      - name: Upload coverage report for player (html)
+        if: always() && hashFiles('dist/coverage/player/tarpaulin-report-player.html') != ''
+        uses: actions/upload-artifact@v4
+        with:
+          name: code-coverage-html-player
+          path: dist/coverage/player/tarpaulin-report-player.html
 
       # # Step 17: Upload to Codecov
       # - name: Upload to Codecov

scripts/test_coverage.sh

@@ -50,9 +50,7 @@ export RUSTC_BOOTSTRAP=1
 COMMON_MANIFEST="src/common/Cargo.toml"
 AGENT_MANIFEST="src/agent/Cargo.toml"
 TOOLS_MANIFEST="src/tools/Cargo.toml"
-SERVER_MANIFEST="src/server/Cargo.toml"
 APISERVER_MANIFEST="src/server/apiserver/Cargo.toml"
-PLAYER_MANIFEST="src/player/Cargo.toml"
 FILTERGATEWAY_MANIFEST="src/player/filtergateway/Cargo.toml"
 ACTIONCONTROLLER_MANIFEST="src/player/actioncontroller/Cargo.toml"
 STATEMANAGER_MANIFEST="src/player/statemanager/Cargo.toml"
@@ -65,6 +63,7 @@ if [[ -f "$COMMON_MANIFEST" ]]; then
     cd "$(dirname "$COMMON_MANIFEST")"
     cargo tarpaulin --out Html --out Lcov --out Xml \
       --output-dir "$PROJECT_ROOT/$COVERAGE_ROOT/common" \
+      --ignore-panics --no-fail-fast \
       2>&1 | tee -a "$LOG_FILE" || true
   )
   mv "$PROJECT_ROOT/$COVERAGE_ROOT/common/tarpaulin-report.html" "$PROJECT_ROOT/$COVERAGE_ROOT/common/tarpaulin-report-common.html" 2>/dev/null || true
@@ -96,6 +95,7 @@ if [[ -f "$TOOLS_MANIFEST" ]]; then
     cd "$(dirname "$TOOLS_MANIFEST")"
     cargo tarpaulin --out Html --out Lcov --out Xml \
       --output-dir "$PROJECT_ROOT/$COVERAGE_ROOT/tools" \
+      --ignore-panics --no-fail-fast \
       2>&1 | tee -a "$LOG_FILE" || true
   )
   mv "$PROJECT_ROOT/$COVERAGE_ROOT/tools/tarpaulin-report.html" "$PROJECT_ROOT/$COVERAGE_ROOT/tools/tarpaulin-report-tools.html" 2>/dev/null || true
@@ -104,23 +104,29 @@ else
 fi
 
 # === Step 2: Start `filtergateway` and `nodeagent` before apiserver ===
+rm -rf /tmp/pullpiri_shared_rocksdb
+mkdir -p /tmp/pullpiri_shared_rocksdb
+# Make directory writable by all users (container needs write access)
+chmod 777 /tmp/pullpiri_shared_rocksdb
 start_service "$FILTERGATEWAY_MANIFEST" "filtergateway"
 start_service "$AGENT_MANIFEST" "nodeagent"
+start_service "$STATEMANAGER_MANIFEST" "statemanager"
 sleep 3
 
 # === SERVER ===
-if [[ -f "$SERVER_MANIFEST" ]]; then
-  echo "📂 Running tarpaulin for server" | tee -a "$LOG_FILE"
+if [[ -f "$APISERVER_MANIFEST" ]]; then
+  echo "📂 Running tarpaulin for server (apiserver)" | tee -a "$LOG_FILE"
   mkdir -p "$COVERAGE_ROOT/server"
   (
-    cd "$(dirname "$SERVER_MANIFEST")"
+    cd "$(dirname "$APISERVER_MANIFEST")"
     cargo tarpaulin --out Html --out Lcov --out Xml \
       --output-dir "$PROJECT_ROOT/$COVERAGE_ROOT/server" \
+      --skip-clean --ignore-panics --no-fail-fast \
       2>&1 | tee -a "$LOG_FILE" || true
   )
   mv "$PROJECT_ROOT/$COVERAGE_ROOT/server/tarpaulin-report.html" "$PROJECT_ROOT/$COVERAGE_ROOT/server/tarpaulin-report-server.html" 2>/dev/null || true
 else
-  echo "::warning ::$SERVER_MANIFEST not found. Skipping..." | tee -a "$LOG_FILE"
+  echo "::warning ::$APISERVER_MANIFEST not found. Skipping..." | tee -a "$LOG_FILE"
 fi
 
 # Stop background services before next round
@@ -143,18 +149,19 @@ start_service "$STATEMANAGER_MANIFEST" "statemanager"
 # Note: RocksDB data cleanup handled by service or via gRPC API if needed
 sleep 3
 
-if [[ -f "$PLAYER_MANIFEST" ]]; then
-  echo "📂 Running tarpaulin for player" | tee -a "$LOG_FILE"
+if [[ -f "$FILTERGATEWAY_MANIFEST" ]]; then
+  echo "📂 Running tarpaulin for player (filtergateway)" | tee -a "$LOG_FILE"
   mkdir -p "$COVERAGE_ROOT/player"
   (
-    cd "$(dirname "$PLAYER_MANIFEST")"
+    cd "$(dirname "$FILTERGATEWAY_MANIFEST")"
     cargo tarpaulin --out Html --out Lcov --out Xml \
       --output-dir "$PROJECT_ROOT/$COVERAGE_ROOT/player" \
+      --ignore-panics --no-fail-fast \
       2>&1 | tee -a "$LOG_FILE" || true
   )
   mv "$PROJECT_ROOT/$COVERAGE_ROOT/player/tarpaulin-report.html" "$PROJECT_ROOT/$COVERAGE_ROOT/player/tarpaulin-report-player.html" 2>/dev/null || true
 else
-  echo "::warning ::$PLAYER_MANIFEST not found. Skipping..." | tee -a "$LOG_FILE"
+  echo "::warning ::$FILTERGATEWAY_MANIFEST not found. Skipping..." | tee -a "$LOG_FILE"
 fi
 
 cleanup

src/server/apiserver/tests/filtergateway_integration.rs

@@ -47,6 +47,7 @@ spec:
 
 /// Test sending with valid scenario and Action::Apply
 #[tokio::test]
+#[ignore = "Requires FilterGateway service to be running"]
 async fn test_send_with_valid_scenario_apply() {
     let scenario = HandleScenarioRequest {
         action: Action::Apply.into(),
@@ -59,6 +60,7 @@ async fn test_send_with_valid_scenario_apply() {
 
 /// Test sending with valid scenario and Action::Withdraw
 #[tokio::test]
+#[ignore = "Requires FilterGateway service to be running"]
 async fn test_send_with_valid_scenario_withdraw() {
     let scenario = HandleScenarioRequest {
         action: Action::Withdraw.into(),