Progress monitor is null

[kenwenzel]

Dear RAP team,

I currently face the problem that with RAP 3.29.0 the following exception occurs

org.eclipse.core.runtime.AssertionFailedException: null argument:
        at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:92)
        at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:79)
        at org.eclipse.core.runtime.ProgressMonitorWrapper.<init>(ProgressMonitorWrapper.java:40)
        at net.enilink.komma.edit.ui.dialogs.FilteredList$GranualProgressMonitor.<init>(FilteredList.java:1593)
        at net.enilink.komma.edit.ui.dialogs.FilteredList$FilterJob.run(FilteredList.java:1789)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

due to passing a null value for the progress monitor to a job.

I think this is somehow related to JobManagerAdapter.scheduled

org.eclipse.rap/bundles/org.eclipse.rap.ui.workbench/Eclipse UI/org/eclipse/rap/ui/internal/progress/JobManagerAdapter.java

Line 151 in 28474ab

public void scheduled( final IJobChangeEvent event ) {

which is indirectly called from a background thread in org.eclipse.core.internal.jobs.Worker.run().

Therefore the display cannot be found as there is no context registered and ContextProvider.hasContext() returns false.

Is this a known problem or am I doing something wrong?

Best regards,
Ken

[kenwenzel]

OK, I think it is due to the following code in JobManager:

	protected void schedule(InternalJob job, long delay) {
		withWriteLock(job, j -> {
			if (scheduleInternal(job, delay, false)) {
				pool.jobQueued();
			}
			return (Void) null;
		});
	}

If the job is scheduled then pool.jobQueued() is directly called. If now the worker picks up the job before withWriteLock is finished the scheduled event is not yet sent and the display can't be found.

[kenwenzel]

My workaround for the problem is:
https://github.com/enilink/enilink/blob/3dc61c02eda6ca8f83afb4cc5b77143e32bc35fe/bundles/workbench/net.enilink.platform.workbench/src/main/java/net/enilink/platform/workbench/Application.java#L64