Copy constructor of the Image class is not working with SWT.IMAGE_COPY

[shlxue]

In hop-web issue: apache/hop#3508

in GuiResource.java#loadAsResource method

    SwtUniversalImage img =
        SwtSvgImageUtil.getUniversalImage(display, getClass().getClassLoader(), location);
    Image image;
    if (size > 0) {
      int newSize = (int) Math.round(size * zoomFactor);
      image = new Image(display, img.getAsBitmapForSize(display, newSize, newSize), SWT.IMAGE_COPY);
    } else {
      image = new Image(display, img.getAsBitmap(display), SWT.IMAGE_COPY);
    }
    img.dispose(); // dispose source image instance: img.getAs...
    return image;

Image.java#200(using reference?): internalImage = srcImage.internalImage;

[ifurnadjiev]

The SWT.IMAGE_COPY style flag is supported since RAP 1.3. I don't understand what is not working. Can you provide a simple self-running snippet (EntryPoint) to demonstrate the issue?

[shlxue]

Copy constructor: Image( Device device, Image srcImage, int flag )

Sample code:

  Image srcImage = ... // An exist instance
  Image copyImage = new Image(device, srcImage, SWT.IMAGE_COPY);
  srcImage.dispose();
  assert copyImage.isDispose(); // the copyImage instance should not be dispose
  MenuItem item = new MenuItem (...);
  item.setImage(copyImage); // error

the sample code works fine in SWT, but doesn't work in RWT

@ifurnadjiev

[ifurnadjiev]

    Display display = parent.getDisplay();
    Image srcImage = new Image( display, 100, 100 );
    Image copyImage = new Image( display, srcImage, SWT.IMAGE_COPY );
    srcImage.dispose();

    System.out.println( copyImage.isDisposed() ); // returns false

    item.setImage( copyImage );

This code works for me with RAP 4.2 RC1. Which RAP version are you using?

[shlxue]

3.24.0

[ifurnadjiev]

Please create a complete self-running snippet to demonstrate the issue. Please attach the error stack trace.

[ifurnadjiev]

Do you have any additional information about the issue?

[shlxue]

I'll send out more information when I try to reproduce the bug

[ifurnadjiev]

Any progress here?