Skip to content

Commit faa7609

Browse files
bemerybmwcastler
authored andcommitted
mw/com: Reduce duplicate coverity information
Issue: SWP-197911 GIT_ORIGIN_SPP_REV_ID: 4ba7d750265eb9675a0a20a3aecfcb4768b1d465
1 parent 236d065 commit faa7609

File tree

1 file changed

+3
-21
lines changed

1 file changed

+3
-21
lines changed

score/mw/com/impl/plumbing/sample_allocatee_ptr.h

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -89,37 +89,19 @@ class SampleAllocateePtr
8989

9090
/// \brief Checks whether *this owns an object, i.e. whether Get() != nullptr
9191
/// \return true if *this owns an object, false otherwise.
92-
// Suppress "AUTOSAR C++14 A15-5-3" rule finding. This rule states: "The std::terminate() function shall
93-
// not be called implicitly.". std::visit Throws std::bad_variant_access if
94-
// as-variant(vars_i).valueless_by_exception() is true for any variant vars_i in vars. The variant may only become
95-
// valueless if an exception is thrown during different stages. Since we don't throw exceptions, it's not possible
96-
// that the variant can return true from valueless_by_exception and therefore not possible that std::visit throws
97-
// an exception.
98-
// This suppression should be removed after fixing [Ticket-173043](broken_link_j/Ticket-173043)
92+
// Suppress "AUTOSAR C++14 A15-5-3" rule finding: See rationale above (fix in Ticket-173043)
9993
// coverity[autosar_cpp14_a15_5_3_violation : FALSE]
10094
explicit operator bool() const noexcept;
10195

10296
/// \brief operator* and operator-> provide access to the object owned by *this. If no object is hold, will
10397
/// terminate.
104-
// Suppress "AUTOSAR C++14 A15-5-3" rule finding. This rule states: "The std::terminate() function shall
105-
// not be called implicitly.". std::visit Throws std::bad_variant_access if
106-
// as-variant(vars_i).valueless_by_exception() is true for any variant vars_i in vars. The variant may only become
107-
// valueless if an exception is thrown during different stages. Since we don't throw exceptions, it's not possible
108-
// that the variant can return true from valueless_by_exception and therefore not possible that std::visit throws
109-
// an exception.
110-
// This suppression should be removed after fixing [Ticket-173043](broken_link_j/Ticket-173043)
98+
// Suppress "AUTOSAR C++14 A15-5-3" rule finding: See rationale above (fix in Ticket-173043)
11199
// coverity[autosar_cpp14_a15_5_3_violation : FALSE]
112100
typename std::add_lvalue_reference<SampleType>::type operator*() const noexcept(noexcept(*std::declval<pointer>()));
113101

114102
/// \brief operator* and operator-> provide access to the object owned by *this. If no object is hold, will
115103
/// terminate.
116-
// Suppress "AUTOSAR C++14 A15-5-3" rule finding. This rule states: "The std::terminate() function shall
117-
// not be called implicitly.". std::visit Throws std::bad_variant_access if
118-
// as-variant(vars_i).valueless_by_exception() is true for any variant vars_i in vars. The variant may only become
119-
// valueless if an exception is thrown during different stages. Since we don't throw exceptions, it's not possible
120-
// that the variant can return true from valueless_by_exception and therefore not possible that std::visit throws
121-
// an exception.
122-
// This suppression should be removed after fixing [Ticket-173043](broken_link_j/Ticket-173043)
104+
// Suppress "AUTOSAR C++14 A15-5-3" rule finding: See rationale above (fix in Ticket-173043)
123105
// coverity[autosar_cpp14_a15_5_3_violation : FALSE]
124106
pointer operator->() const noexcept;
125107

0 commit comments

Comments
 (0)