Skip to content

Commit 38dcca7

Browse files
committed
Remove the separate build step
Maybe caching does not work as expected, and with this, the publish step at the latest will definitely build the images.
1 parent 78d9bb5 commit 38dcca7

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

.github/workflows/ci.yaml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,10 @@ jobs:
4646
# Create builder for multi-arch builds
4747
./scripts/create_builder.sh
4848
49-
# Build
50-
./scripts/build.sh "main"
51-
52-
# Test
49+
# Build & Test (amd64-only for tests to be fast)
5350
./scripts/test.sh
5451
55-
# Optionally: Publish
52+
# Optionally (if on main branch): Publish (multi-arch: amd64, arm64)
5653
# We do not use the push feature of devcontainers/ci here, since that would push the wrong container.
5754
# Instead, we use the publish script which pushes the correct container (residing in src/s-core-devcontainer).
5855
if [ "${{ github.ref }}" = "refs/heads/main" ]; then

.github/workflows/release.yaml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,10 @@ jobs:
4141
# Create builder for multi-arch builds
4242
./scripts/create_builder.sh
4343
44-
# Build
45-
./scripts/build.sh "${{ github.ref_name }}" "latest"
46-
47-
# Test
44+
# Build & Test (amd64-only for tests to be fast)
4845
./scripts/test.sh
4946
50-
# Publish
47+
# Publish (multi-arch: amd64, arm64)
5148
# We do not use the push feature of devcontainers/ci here, since that would push the wrong container.
5249
# Instead, we use the publish script which pushes the correct container (residing in src/s-core-devcontainer).
5350

0 commit comments

Comments
 (0)